fix(layer): emit absolute sitemap URLs from configured site.url - #1422
Open
TerrorSquad wants to merge 1 commit into
Open
fix(layer): emit absolute sitemap URLs from configured site.url#1422TerrorSquad wants to merge 1 commit into
TerrorSquad wants to merge 1 commit into
Conversation
|
@TerrorSquad is attempting to deploy a commit to the NuxtLabs Team on Vercel. A member of the Team first needs to authorize it. |
TerrorSquad
force-pushed
the
fix/sitemap-absolute-loc
branch
from
August 10, 2026 21:58
c9651e2 to
80c6a19
Compare
TerrorSquad
force-pushed
the
fix/sitemap-absolute-loc
branch
from
August 10, 2026 22:25
80c6a19 to
e618756
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
/sitemap.xmlgets its base URL frominferSiteURL(), which only reads env vars. Asite.urlset innuxt.configis ignored, so it falls back to''and every entry comes out relative:The sitemap spec requires absolute URLs, so search engines reject these. Nothing warns at build time.
Reproduction
Set
site: { url: 'https://example.com' }innuxt.config, no env vars, thennuxt buildand fetch/sitemap.xml.Fix
Expose the resolved
site.urlonruntimeConfig.public.site, the same waymcp.routeis already exposed, and read it in the route.inferSiteURL()stays as the fallback so env-var deploys are unaffected.Verified
site.urlin configpnpm lintandpnpm typecheckpass.Note
pnpm installfails on a clean checkout:packageManagerpinspnpm@11.13.0, which shipped a broken binary. Not related to this PR, happy to file separately.