Get siteKey from env variable #45
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinayakkulkarni
approved these changes
Jul 20, 2020
Contributor
|
Thank you for the PR, I think #70 will actually do the same work with the advantage or working when changing |
Author
|
@atinux I'm not too deep into the runtime config feature, so if it does the same I'd be fine with closing the PR. Also, I've changed my convention to directly pass environment variables, so it's not that important for me anymore. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's common practice to store API keys in environment variables so they aren't versioned. This PR fallbacks to an env variable when siteKey is not explicitly set.