This repository was archived by the owner on Jul 15, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 34
feat: template improvements #74
Open
danielroe
wants to merge
23
commits into
template
Choose a base branch
from
template-improvements
base: template
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* use `upath` for better windows support * inline package.json name/version * type options as as Partial by default * give example of typed access to normalised nuxt options * correct `defu` type error * add package exports
Codecov Report
@@ Coverage Diff @@
## template #74 +/- ##
===========================================
Coverage ? 75.00%
===========================================
Files ? 2
Lines ? 12
Branches ? 2
===========================================
Hits ? 9
Misses ? 3
Partials ? 0 Continue to review full report at Codecov.
|
danielroe
commented
Mar 9, 2021
pi0
suggested changes
Mar 9, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please avoid boilerplate inside template
danielroe
commented
Mar 11, 2021
Comment on lines
+11
to
+13
moduleNameMapper: { | ||
npm_package: '<rootDir>/src' | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
moduleNameMapper: { | |
npm_package: '<rootDir>/src' | |
}, |
Looks like this causes issues with importing of other npm packages.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO from #70:
(siroc needs alias support)