Skip to content
This repository was archived by the owner on Jul 15, 2022. It is now read-only.

feat: template improvements #74

Open
wants to merge 23 commits into
base: template
Choose a base branch
from
Open

Conversation

danielroe
Copy link
Member

@danielroe danielroe commented Mar 9, 2021

TODO from #70:

* use `upath` for better windows support
* inline package.json name/version
* type options as as Partial by default
* give example of typed access to normalised nuxt options
* correct `defu` type error
* add package exports
@danielroe danielroe changed the base branch from master to template March 9, 2021 10:19
@danielroe danielroe changed the base branch from template to master March 9, 2021 10:23
@codecov
Copy link

codecov bot commented Mar 9, 2021

Codecov Report

❗ No coverage uploaded for pull request base (template@e21b924). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             template      #74   +/-   ##
===========================================
  Coverage            ?   75.00%           
===========================================
  Files               ?        2           
  Lines               ?       12           
  Branches            ?        2           
===========================================
  Hits                ?        9           
  Misses              ?        3           
  Partials            ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e21b924...ea7efa3. Read the comment docs.

@danielroe danielroe changed the base branch from master to template March 9, 2021 10:44
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please avoid boilerplate inside template

@danielroe danielroe marked this pull request as ready for review March 9, 2021 11:42
@danielroe danielroe requested a review from pi0 March 9, 2021 11:42
Comment on lines +11 to +13
moduleNameMapper: {
npm_package: '<rootDir>/src'
},
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
moduleNameMapper: {
npm_package: '<rootDir>/src'
},

Looks like this causes issues with importing of other npm packages.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants