Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(local): prevent loggedIn being incorrectly set to true when user is disabled #346

Merged
merged 1 commit into from
May 23, 2019

Conversation

glennjacobs
Copy link
Contributor

This fixes an issue with the local scheme which sets the user to {} even if there's no token, which causes loggedIn to report true, when in fact it's false.

This fixes an issue with the local scheme which sets the user to `{}` even if there's no token, which causes loggedIn to report true, when in fact it's false.
@atinux atinux self-requested a review May 9, 2019 09:34
Copy link
Member

@atinux atinux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pi0 pi0 added the fix label May 23, 2019
@pi0 pi0 changed the title Fix to prevent loggedIn being incorrectly set to true Prevent loggedIn being incorrectly set to true May 23, 2019
@pi0 pi0 changed the title Prevent loggedIn being incorrectly set to true fix: prevent loggedIn being incorrectly set to true May 23, 2019
@pi0 pi0 changed the title fix: prevent loggedIn being incorrectly set to true fix(local): prevent loggedIn being incorrectly set to true when user is disabled May 23, 2019
@pi0 pi0 merged commit aa5f29d into nuxt-community:dev May 23, 2019
This was referenced May 23, 2019
@pi0
Copy link
Member

pi0 commented May 30, 2019

This PR has been published in v4.6.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants