Option to set auth header name #301
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
farnabaz
requested changes
Feb 9, 2019
| @@ -7,6 +7,8 @@ export default class Auth { | |||
| constructor (ctx, options) { | |||
| this.ctx = ctx | |||
| this.options = options | |||
|
|
|||
| this.authHeaderName = options.authHeader || 'Authorization'; | |||
There was a problem hiding this comment.
There is no need for the authHeader option, strategies have an option called tokenName.
Using that option will solve the problem
this.authHeaderName = strategy.options.tokenName || 'Authorization'
pi0
pushed a commit
that referenced
this pull request
May 23, 2019
Co-authored-by: @terion-name Co-authored-by: @farnabaz
|
Thanks, @terion-name, @farnabaz. I've implemented it in 8654a48. Core now prefers strategy's |
Merged
|
Change has been published in v4.6.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are some scenarios, mostly due to some specific business logic, when one need to customize auth headers. Currently there is no possibility to do this. This patch adds a possibility to set header name via option