Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support custom rule classes in @rules and @rulesForArray #812

Merged
merged 15 commits into from
May 26, 2019
Merged

Support custom rule classes in @rules and @rulesForArray #812

Changes from 4 commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
3fe863b
Support custom rules.
oozman May 25, 2019
a56cb9a
Remove extra line.
oozman May 25, 2019
775ebba
Re-arrange namespaces.
oozman May 25, 2019
209107b
Use resolve() instead.
oozman May 25, 2019
8d8ba02
Use class_exists().
oozman May 26, 2019
aafea7b
Resolve custom rule classes in @rulesForArray directive.
oozman May 26, 2019
5d643f7
Add custom rule tests.
oozman May 26, 2019
ad30cf8
Update docs.
oozman May 26, 2019
a4830ae
Update CHANGELOG.
oozman May 26, 2019
831e6c4
StyleCI thing.
oozman May 26, 2019
25e088a
Move docs for new feature to master
spawnia May 26, 2019
ad99a71
Clarify comment
spawnia May 26, 2019
0fb1126
Add PR link to changelog
spawnia May 26, 2019
07a10c1
Simplify rules test and assert the rule is actually called
spawnia May 26, 2019
8ab4d20
style
spawnia May 26, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/Schema/Directives/RulesDirective.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,13 @@ public function getRules(): array
{
$rules = $this->directiveArgValue('apply');

// Resolve custom rule namespace, if possible.
foreach ($rules as $key => $rule) {
if (strpos($rule, 'App\Rules') === 0) {
spawnia marked this conversation as resolved.
Show resolved Hide resolved
$rules[$key] = resolve($rule);
}
}

return [$this->argumentPathAsDotNotation() => $rules];
}

Expand Down