Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor fixes (lines 05, 12) #88

Merged
merged 3 commits into from
Jul 17, 2021
Merged

Minor fixes (lines 05, 12) #88

merged 3 commits into from
Jul 17, 2021

Conversation

kant
Copy link
Contributor

@kant kant commented Jun 16, 2021

Purpose of the pull request
The purpose of the pull request. (e.g. Fix Bug, Feature request)
Enhance documentation on lines 05, 12

Description about the pull request
The description about this pull request.
Typos fixed

Additional comments [Optional]
No break on code. Just clear and enhanced documentation

Copy link
Owner

@nutti nutti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR. @kant

I have a minor comment for your PR.
Could you check it?

README.md Outdated Show resolved Hide resolved
@nutti nutti added the bug label Jun 16, 2021
Copy link
Owner

@nutti nutti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed status to request change.

@nutti
Copy link
Owner

nutti commented Jul 3, 2021

@kant

Is there any update about this PR?

@nutti nutti self-requested a review July 17, 2021 01:45
Copy link
Owner

@nutti nutti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @kant !

@nutti nutti merged commit e5535d0 into nutti:master Jul 17, 2021
nutti pushed a commit that referenced this pull request Jul 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants