Tracking_eval refactor #660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
holger-motional
approved these changes
Sep 16, 2021
mengnutonomy
force-pushed
the
APF-2610/move_tracking_names_to_config_file
branch
from
68de50f to
68e06c5
Compare
holger-motional
approved these changes
Sep 16, 2021
| assert set(class_range.keys()) == set(TRACKING_NAMES), "Class count mismatch." | ||
|
|
||
| assert set(class_range.keys()) == set(tracking_names), "Class count mismatch." | ||
| global TRACKING_NAMES |
There was a problem hiding this comment.
why you need to define it as global rather than just use self.tracking_names
There was a problem hiding this comment.
It is needed here, and I donot want to change
TrackingBox to include extra things.
There was a problem hiding this comment.
okay, then it's better to define this global variable at the beginning of this file, since it's shared by the 2 classes.
lubing-motional
approved these changes
Sep 20, 2021
added 3 commits
September 20, 2021 13:21
…into APF-2610/move_tracking_names_to_config_file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the fields TRACKING_NAMES, PRETTY_TRACKING_NAMES and TRACKING_COLORS from constants.py to the config json file. This way users can use the tracking eval code on custom datasets with different classes.