Skip to content

Release v1.0.0 #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 103 commits into from
Mar 25, 2019
Merged

Release v1.0.0 #64

merged 103 commits into from
Mar 25, 2019

Conversation

oscar-nutonomy
Copy link
Contributor

@oscar-nutonomy oscar-nutonomy commented Mar 14, 2019 •
edited by Alex-nutonomy
Loading

Base-branch for release v1.0.0. TODOs:

  • Updated README and install instructions.
  • Move setup files to setup folder. [CL]
  • Update README for debris [OB]
  • Filter on bike-racks during eval. [SV]
  • Simple eval tests. [VB]
  • Update eval renderers. [VB]
  • Add back the CLI. [VB]
  • Test TP metrics. [VB]
  • Update visualize_sample to operate on new structs. [VB]
  • create_split_scenes() currently gives access to all split. It shouldn't be allowed.
    ---- OPTIONAL ----
  • Fix quaternion_yaw method to be valid for all frames. Or make frame req. more explicit. [OB]
  • Look into adding box velocity by default. [OB]
  • More tests. [VB]
  • Unit-tests for orientation evaluation. [VB]
  • Either make evaluation rendering independent of rest of eval code or add deserialize to DetectionMetrics

holger-motional and others added 30 commits January 21, 2019 17:33
@holger-motional
Added setup.py for pip installation
251d0c0
@holger-motional
Added speedup to query many points with single function call in map mask
011934e
@holger-motional
Added missing methods for improved map mask
4dc1894
@holger-motional
Merge branch 'pip' into map_mask_speedup
9511d18
@holger-motional
Merge branch 'master' into map_mask_speedup
e468e8c
@holger-motional
Changes for v0.2
6fb79ae
@holger-motional
Updated tutorial path
082e074
@holger-motional
Changed logic s.t. map table points to logs, not 1 to 1
713ad90
@holger-motional
Fix indexing bug
1a7d1fc
@holger-motional
Reset paths to default
7b6abbf
@holger-motional
Removed print statement from setup.py
ab7952a
@holger-motional
Merge remote-tracking branch 'origin/master' into release_v0.2
cbf85f9
@holger-motional
Fixed a bug for large map files
b0f15e8
@holger-motional
Not excluding any logs from map rendering
5182209
@holger-motional
Fixed bug with missing "self" keyword in create_splits_logs(nusc), ad…
25b3f38 
…ded dataroot parameter
@holger-motional
Address bug for classes without attributes
9465790
@holger-motional
Fixed misspelled motorcycle
586176d
@holger-motional
Added missing keyword self
f403e6f
@holger-motional
Added checks for nan values
55d2bcf
@holger-motional
Removed teaser splits as they is not compatible with the new logs
88464a4
@holger-motional
Added (preliminary) splits for v0.2
518516c
@holger-motional
Workaround to allow evaluating a subset of the data
d8dbc91
@holger-motional
Splits hardcoded in create_splits_logs
3cc23b6
Fix bugs if a results file has zero TPs
94544b5
@sourabh-nutonomy @holger-motional
Simpler MapMask (#31)
7f92d44 
* deleted distance_mask, binary_mask. Created dilate_mask().
* cleanup docstring
@holger-motional @oscar-nutonomy
Added missing Dict import (#35)
44a65fa
@holger-motional @oscar-nutonomy
Typing fix (#36)
c11d27d 
* Added missing Dict import
* Fixed typing to be compatible where future annotations package cannot be loaded
@oscar-nutonomy
Devkit now accepts versions 0.3, 0.4 and 1.0
7c7faa0
@holger-motional @oscar-nutonomy
Updated code to new folder structure (#37)
f57620b
@holger-motional @oscar-nutonomy
Fix TPs analog to commit 94544b5 (#41)
f382c9c
varun-nutonomy and others added 20 commits March 19, 2019 18:20
@varun-nutonomy @oscar-nutonomy
Simple Unittests for AP calculation (#82)
a62b9e7 
* Clean up old unit tests and added tests for AP calculation
@Alex-nutonomy
Revert setup changes to get CI working (#84)
a6608cd 
* Revert "* Moved continuous integration and Docker dependencies to 'setup' folder. (#80)"

This reverts commit fa55433.

* revert setup.py changes
@sourabh-nutonomy @Alex-nutonomy
Bikerack filtering (#83)
c3f9cc8 
* spellcheck

* add points_in_box() method to check whether points are inside the box

* test points_in_box() method

* perform bike rack filtering

* docstring for filter_eval_boxes

* added unittests for filter_eval_boxes()

* update comment

* fix docstring

* can't use Box type because of a circular import. So switched to 'Box'

* can't use Box type because of a circular import. So switched to 'Box'

* change threshold after bikerack filtering

* get max_dist from eval_detection_configs
@varun-nutonomy @oscar-nutonomy
Update eval renderers (#85)
72861d0 
* Updated renderers for detection results. 
* Fixed bugs in detection evaluation.
@venice-erin @oscar-nutonomy
Added color options for render_egoposes_on_map (#86)
b03a66c 
* add color option for render maps
@varun-nutonomy @Alex-nutonomy
Summary AP plot update (#87)
c5aa9c6 
* updated the plots

* better legend text alignment

* updated legend positions and pretty names for attributes and TP metrics

* Tex table (#91)

* added reder tex table

* cleaned up tex render method

* minor changes

* add credits

* misc cleanup
@holger-motional @Alex-nutonomy
Instruction updates and misc (#89)
9b918e2 
* Set default version for export egoposes, better outputs

* Added v1.0 to legal datasets

* Corrected visibility level

* Set face color to black, better status messages

* Updated face color

* Set set to trainval in misc scripts

* Bugfix to preserver black bg color

* Made close_dist a parameter

* Merged truck classes in the instructions

* Removed train from instructions

* Merged police officers into single class

* Reset changes to tutorial

* Updated path to requirements.txt

* Removed v1.0 which was used for setup purposes

* Cleanup

* Fix visibility levels in instructions

* Also print empty categories

* Fixed bug

* Reversed previous changes

* Updated schema comments for map

* Reverted previous changes

* misc cleanup
@Alex-nutonomy
next pip package
08dfd36
@varun-nutonomy
added unittests for TP metrics
d8f1e35
@holger-motional
Readme update (#93)
dbc54e1 
* OVerhauled eval detection page

* Overhauled main readme

* Removed deprecated links

* Rewording

* Addressed review comments
@varun-nutonomy
fixed the visualize sample, need to test it
49c859e
@varun-nutonomy
rebased to releasev0.2 branch
f227bfb
@varun-nutonomy
added comments to unit tests
e79f25a
@sergi-nutonomy @oscar-nutonomy
[WIP] Jupyter notebook tutorial (#90)
0db3923 
* Updated tutorial
@varun-nutonomy @oscar-nutonomy
Unittests for true positive error metrics calculation (#92)
ec4c269 
* added unittests for TP metrics

* fixed visualize sample

* added comments to unit tests
@varun-nutonomy
added option to save sample rendering to disk
9eb602a
@varun-nutonomy
added option to save sample renderings
06c1ffb
@varun-nutonomy
added back showing plot if savepath is not given
d608398
@bassam-nutonomy
Update README.md
c73ce07 
Clarifications
@bassam-nutonomy
Update schema.md
23bd7fa 
added an example for subcategories
@bassam-nutonomy
Copy link

bassam-nutonomy commented Mar 25, 2019 •
edited
Loading

I made the following changes to the README:

  • confirm the terms of service -> agree to the terms of service
  • If you want to use another folder, specify the dataroot parameter of the NuScenes class below. -> nuscenes isn't mentioned below so I said: dataroot parameter of the NuScenes class (see tutorial)

Changes to schema.md:

  • Taxonomy of object categories (e.g. vehicle, human). Subcategories are delineated by a period -> Taxonomy of object categories (e.g. vehicle, human). Subcategories are delineated by a period (e.g. human.pedestrian.adult).

@Alex-nutonomy Alex-nutonomy merged commit 0334132 into master Mar 25, 2019
@Alex-nutonomy Alex-nutonomy deleted the release_v0.2 branch March 25, 2019 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Qiang-Xu Qiang-Xu Qiang-Xu left review comments

@Alex-nutonomy Alex-nutonomy Alex-nutonomy approved these changes

Assignees

@oscar-nutonomy oscar-nutonomy

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.