Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add radar dtype bugfix and test, addresses #588 #589

Merged
merged 2 commits into from
Apr 20, 2021
Merged

Add radar dtype bugfix and test, addresses #588 #589

merged 2 commits into from
Apr 20, 2021

Conversation

holger-motional
Copy link
Contributor

This PR fixes a bug reported in #588.
It also adds a test to check for future regression.

@holger-motional holger-motional self-assigned this Apr 20, 2021
@holger-motional holger-motional mentioned this pull request Apr 20, 2021
Closed
whyekit-motional
whyekit-motional approved these changes Apr 20, 2021
View reviewed changes
Copy link
Collaborator

@whyekit-motional whyekit-motional left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall! Just one minor comment

python-sdk/nuscenes/utils/tests/test_data_classes.py Outdated Show resolved Hide resolved
@holger-motional holger-motional merged commit 68eb618 into master Apr 20, 2021
@holger-motional holger-motional deleted the dtype_bugfix branch April 20, 2021 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whyekit-motional whyekit-motional whyekit-motional approved these changes

@kokseang-motional kokseang-motional Awaiting requested review from kokseang-motional

Assignees

@holger-motional holger-motional

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@holger-motional @whyekit-motional