Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove torch/motmetrics/pandas requirements and skip related tests #510

Merged
merged 2 commits into from
Dec 7, 2020

Conversation

holger-motional
Copy link
Contributor

This PR removes the tracking and prediction requirements from the default nuscenes-devkit installation. They can still be installed manually. The major implication of this is that all unit test which require these packages would fail. We therefore catch ModuleNotFoundErrors when importing the modules torch, motmetrics and pandas.

Here is the test output without those requirements installed:

...........................ssss.............................................................................
----------------------------------------------------------------------
Ran 179 tests in 21.658s

Here is the test output with those requirements installed:

...........................................................................................................................
----------------------------------------------------------------------
Ran 203 tests in 36.815s

OK

Copy link
Collaborator

@whyekit-motional whyekit-motional left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@holger-motional holger-motional merged commit 5f337c5 into master Dec 7, 2020
@holger-motional holger-motional deleted the remove_torch branch December 7, 2020 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants