Skip to content

Modify MSBuild command, version upgrades #178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 10, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 5 additions & 8 deletions .github/workflows/build-validate.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -24,21 +24,18 @@ jobs:
runs-on: ${{ matrix.os }}
strategy:
matrix:
os: [windows-2019] # Should have MSBuild.
os: [windows-latest] # Should have MSBuild.
steps:
# Make MSBuild available from $PATH.
- name: setup-msbuild
uses: microsoft/setup-msbuild@v1.1
uses: microsoft/setup-msbuild@v2

- name: Checkout Code
uses: actions/checkout@v3

- name: Restore Packages
run: msbuild -t:restore
uses: actions/checkout@v4

# msbuild cannot handle .vdproj Installer projects, so only build debug for now.
- name: Build solution
run: msbuild $env:SLN_FILE -p:Configuration=Debug
run: msbuild -t:build -restore -p:Configuration=Debug $env:SLN_FILE

# For now, let msbuild continue autogenerating assembly versions and base everything off of that.
- name: Get AssemblyVersion generated by msbuild
Expand All @@ -48,7 +45,7 @@ jobs:
directory: ${{ env.DEBUG_OUTPUT }}

- name: Upload Artifact
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: ${{ format('WinNUT-Client-debugbuild-v{0}', steps.getversion.outputs.version) }}
if-no-files-found: error
Expand Down