Use correct API endpoint for category queries #348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marvin Beckers <marvin@kubermatic.com>
Signed-off-by: Marvin Beckers <marvin@kubermatic.com>
siddharth-nutanix
added
1.3.1
siddharth-nutanix
approved these changes
Feb 21, 2022
|
/ok-to-test
|
siddharth-nutanix
approved these changes
Feb 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey folks, I found this bug while working with the client library downstream. The correct API endpoint
/category/queryis documented here. The current implementation fails with a "method not allowed" error because it's essentially using the "Get a category key" endpoint against a category called "query" (but the endpoint doesn't supportPOST).GetCategoryQuery()does not seem to be used anywhere in the provider, so I'm not sure how interested you are in this fix, but I wanted to send this upstream as it might come in handy in the future. Feel free to close if not relevant.