Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add check for cluster_reference before set to avoid it in case of overlay subnets in datasource nutanix_subnet #328

Merged
merged 1 commit into from
Feb 9, 2022
Merged

Add check for cluster_reference before set to avoid it in case of overlay subnets in datasource nutanix_subnet #328

merged 1 commit into from
Feb 9, 2022

Conversation

bhati-pradeep
Copy link
Collaborator

@bhati-pradeep bhati-pradeep commented Jan 28, 2022 •
edited
Loading

For overlay subnets, there is no cluster_reference field in response. So added a check before setting "cluster_reference_name"

@bhati-pradeep bhati-pradeep linked an issue Jan 28, 2022 that may be closed by this pull request
Provider plugin crashes when nutanix_subnet datasource queried with overlay subnet #327
Closed
@bhati-pradeep bhati-pradeep changed the title add check for cluster_reference before set to avoid it in case of overlay subnets Add check for cluster_reference before set to avoid it in case of overlay subnets in datasource nutanix_subnet Jan 28, 2022
@siddharth-kulshrestha
Copy link
Contributor

/ok-to-test

@siddharth-nutanix
Copy link
Collaborator

siddharth-nutanix commented Feb 2, 2022 •
edited by github-actions bot
Loading

/ok-to-test

Acceptance test run status: failure

@bhati-pradeep bhati-pradeep force-pushed the bugfix/fix-308-datasource-query-overlay-subnet branch from cd880c5 to b2d1093 Compare February 8, 2022 18:49
@bhati-pradeep
Copy link
Collaborator Author

bhati-pradeep commented Feb 8, 2022 •
edited by github-actions bot
Loading

/ok-to-test

Acceptance test run status: success
Line code coverage is 60.2

@siddharth-nutanix siddharth-nutanix linked an issue Feb 9, 2022 that may be closed by this pull request
nutanix_projects and nutanix_project throws error when there is external network associated to a project #337
Closed
@siddharth-nutanix siddharth-nutanix removed a link to an issue Feb 9, 2022
nutanix_projects and nutanix_project throws error when there is external network associated to a project #337
Closed
@siddharth-nutanix siddharth-nutanix merged commit d2f50d8 into nutanix:master Feb 9, 2022
@embik embik mentioned this pull request Feb 17, 2022
Merged
@jesse-gonzalez jesse-gonzalez mentioned this pull request Aug 22, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Provider plugin crashes when nutanix_subnet datasource queried with overlay subnet
3 participants
@bhati-pradeep @siddharth-kulshrestha @siddharth-nutanix