Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README and Website for v1.2.0 release. #245

Merged
merged 8 commits into from
Feb 1, 2021
Merged

Update README and Website for v1.2.0 release. #245

merged 8 commits into from
Feb 1, 2021

Conversation

marinsalinas
Copy link
Contributor

A

@gabybeitler
Copy link
Contributor

looks good.

@coderGo93
Copy link
Contributor

looking good so far, in website there's a file for resource and datasource volume_group, is that correct? because it's not in any resource/datasource unless is in another branch

yannickstruyf3
yannickstruyf3 requested changes Feb 1, 2021
View reviewed changes
Copy link
Collaborator

@yannickstruyf3 yannickstruyf3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some copy-paste mistakes in permission docs (still referring to projects)

website/docs/d/permission.html.markdown Outdated Show resolved Hide resolved
website/docs/d/permission.html.markdown Outdated Show resolved Hide resolved
website/docs/d/permission.html.markdown Outdated Show resolved Hide resolved
website/docs/d/permission.html.markdown Outdated Show resolved Hide resolved
@yannickstruyf3
Copy link
Collaborator

looking good so far, in website there's a file for resource and datasource volume_group, is that correct? because it's not in any resource/datasource unless is in another branch

Volume_groups are not supported. Docs should be removed

yannickstruyf3
yannickstruyf3 requested changes Feb 1, 2021
View reviewed changes
website/docs/d/permission.html.markdown Outdated Show resolved Hide resolved
website/docs/d/permissions.html.markdown Outdated Show resolved Hide resolved
website/docs/d/permissions.html.markdown Outdated Show resolved Hide resolved
website/docs/d/permissions.html.markdown Outdated Show resolved Hide resolved
website/docs/d/permissions.html.markdown Outdated Show resolved Hide resolved
website/docs/d/permissions.html.markdown Outdated Show resolved Hide resolved
website/docs/d/subnets.html.markdown Outdated Show resolved Hide resolved
website/docs/d/subnets.html.markdown Outdated Show resolved Hide resolved
website/docs/d/subnets.html.markdown Outdated Show resolved Hide resolved
website/docs/d/subnets.html.markdown Outdated Show resolved Hide resolved
@marinsalinas marinsalinas merged commit 8576511 into master Feb 1, 2021
@marinsalinas marinsalinas deleted the readme-v1.2.0 branch February 1, 2021 18:13
yannickstruyf3 pushed a commit to yannickstruyf3/terraform-provider-nutanix that referenced this pull request Nov 9, 2021
@marinsalinas
Merge pull request nutanix#245 from nutanix/readme-v1.2.0
b6a31b9 
Update README and Website for  v1.2.0 release.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabybeitler gabybeitler gabybeitler approved these changes

@yannickstruyf3 yannickstruyf3 yannickstruyf3 approved these changes

@coderGo93 coderGo93 Awaiting requested review from coderGo93

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@marinsalinas @gabybeitler @coderGo93 @yannickstruyf3