Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed unchecked gets in getMetadataAttributes #206

Closed
wants to merge 1 commit into from
Closed

fixed unchecked gets in getMetadataAttributes #206

wants to merge 1 commit into from

Conversation

yannickstruyf3
Copy link
Collaborator

@yannickstruyf3 yannickstruyf3 commented Nov 30, 2020 •
edited
Loading

  • Fix wrong casting
  • [-] Get diff in plan after apply when not passing name ==> Not relevant since this is a typeMap

(enhancement) fix #205

@marinsalinas
Copy link
Contributor

What is missing on this PR?

@marinsalinas
Copy link
Contributor

@yannickstruyf3 can we merge this or is still pending some items?

@yannickstruyf3
Copy link
Collaborator Author

@yannickstruyf3 can we merge this or is still pending some items?

Can be merged. Since it is a typeMap, all attributes should be passed or it will give a diff (see second point above).

@siddharth-nutanix
Copy link
Collaborator

@yannickstruyf3 Is this PR still required ?
If yes then please rebase this PR with master and resolve the conflicts.

@abhimutant
Copy link
Contributor

Closing this PR as it is merged with #380 .

@abhimutant abhimutant closed this Mar 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
1.4 bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Terraform crashed while creating VM in Nutanix
4 participants
@yannickstruyf3 @marinsalinas @siddharth-nutanix @abhimutant