Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed volume_group documentations #160

Merged
merged 1 commit into from
Aug 10, 2020
Merged

Removed volume_group documentations #160

merged 1 commit into from
Aug 10, 2020

Conversation

PacoDw
Copy link
Contributor

@PacoDw PacoDw commented Aug 5, 2020

  • Since the volume groups resource is not part of the Nutanix provider, it was removed

Copy link
Contributor

@coderGo93 coderGo93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@marinsalinas marinsalinas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can keep those files and just remove the link over this: https://github.com/terraform-providers/terraform-provider-nutanix/blob/master/website/nutanix.erb#L19

@PacoDw
Copy link
Contributor Author

PacoDw commented Aug 6, 2020

Thanks, @marinsalinas it's better 👍

@ghost ghost added size/M and removed size/L labels Aug 6, 2020
<% end %>

<%= yield %>
<% end %>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just add trailing line please :)

@PacoDw PacoDw merged commit 4e0a469 into master Aug 10, 2020
@PacoDw PacoDw deleted the removeDocs branch August 10, 2020 13:00
yannickstruyf3 pushed a commit to yannickstruyf3/terraform-provider-nutanix that referenced this pull request Nov 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants