Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set default value of disk_list.device_properties.device_type to DISK #157

Merged

Conversation

maxaudron
Copy link
Contributor

Set the default value of device_type to DISK as mentioned in the documentation.
I also think this is generally practical.

@marinsalinas
Copy link
Contributor

@yannickstruyf3 what do you think about it? any thoughts on adding DISK as the default value?

@siddharth-nutanix
Copy link
Collaborator

@maxaudron Please rebase this PR with master.

@maxaudron maxaudron force-pushed the fix/disk-device-type-default branch from 2626099 to 9dd72c1 Compare February 21, 2022 08:06
@siddharth-nutanix
Copy link
Collaborator

siddharth-nutanix commented Feb 22, 2022

/ok-to-test

Acceptance test run status: success
Line code coverage is 59.5

@siddharth-nutanix siddharth-nutanix merged commit d1cd5dc into nutanix:master Feb 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants