Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added preCheck function to verify that env variables were set #103

Merged
merged 1 commit into from
Mar 24, 2020

Conversation

PacoDw
Copy link
Contributor

@PacoDw PacoDw commented Mar 23, 2020

We can use this function in all the test cases to verify if the environment variables were correctly set.

@ghost ghost added the size/XS label Mar 23, 2020
Copy link
Contributor

@marinsalinas marinsalinas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add it to all acceptance test?

@PacoDw
Copy link
Contributor Author

PacoDw commented Mar 24, 2020

@marinsalinas sure :) do you want those changes in this same PR?

@PacoDw PacoDw requested a review from marinsalinas March 24, 2020 02:51
@marinsalinas
Copy link
Contributor

Yes, please

@PacoDw
Copy link
Contributor Author

PacoDw commented Mar 24, 2020

@marinsalinas I checked all the test and all of them have the function

Copy link
Contributor

@marinsalinas marinsalinas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @PacoDw , LGTM, :shipit:

@PacoDw PacoDw merged commit fb21e01 into master Mar 24, 2020
@PacoDw PacoDw deleted the preCheckEnvVariables branch March 24, 2020 15:18
yannickstruyf3 pushed a commit to yannickstruyf3/terraform-provider-nutanix that referenced this pull request Nov 9, 2021
…riables

Added preCheck function to verify that env variables were set
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants