Add support for CPU passthrough

nutanix · Oct 29, 2021 · e21f85a · e21f85a
1 parent 3d69529
commit e21f85a
Show file tree

Hide file tree

Showing 3 changed files with 35 additions and 2 deletions.
diff --git a/client/v3/v3_structs.go b/client/v3/v3_structs.go
@@ -283,6 +283,9 @@ type VMResources struct {
 	// Indicates whether VGA console should be enabled or not.
 	VgaConsoleEnabled *bool `json:"vga_console_enabled,omitempty" mapstructure:"vga_console_enabled,omitempty"`
 
+	// Indicates whether to passthrough the host’s CPU features to the guest. Enabling this will disable live migration of the VM.
+	EnableCPUPassthrough *bool `json:"enable_cpu_passthrough,omitempty" mapstructure:"enable_cpu_passthrough,omitempty"`
+
 	// Information regarding vNUMA configuration.
 	VMVnumaConfig *VMVnumaConfig `json:"vnuma_config,omitempty" mapstructure:"vnuma_config,omitempty"`
 
@@ -510,6 +513,9 @@ type VMResourcesDefStatus struct {
 	// Indicates whether VGA console has been enabled or not.
 	VgaConsoleEnabled *bool `json:"vga_console_enabled,omitempty" mapstructure:"vga_console_enabled,omitempty"`
 
+	// Indicates whether to passthrough the host’s CPU features to the guest. Enabling this will disable live migration of the VM.
+	EnableCPUPassthrough *bool `json:"enable_cpu_passthrough,omitempty" mapstructure:"enable_cpu_passthrough,omitempty"`
+
 	// Information regarding vNUMA configuration.
 	VnumaConfig *VMVnumaConfig `json:"vnuma_config,omitempty" mapstructure:"vnuma_config,omitempty"`
 

diff --git a/nutanix/data_source_nutanix_virtual_machine.go b/nutanix/data_source_nutanix_virtual_machine.go
@@ -194,7 +194,10 @@ func dataSourceNutanixVirtualMachine() *schema.Resource {
 			},
 
 			// RESOURCES ARGUMENTS
-
+			"enable_cpu_passthrough": {
+				Type:     schema.TypeBool,
+				Computed: true,
+			},
 			"num_vnuma_nodes": {
 				Type:     schema.TypeInt,
 				Computed: true,
@@ -798,6 +801,7 @@ func dataSourceNutanixVirtualMachineRead(d *schema.ResourceData, meta interface{
 	d.Set("name", utils.StringValue(resp.Status.Name))
 	d.Set("description", utils.StringValue(resp.Status.Description))
 	d.Set("state", utils.StringValue(resp.Status.State))
+	d.Set("enable_cpu_passthrough", utils.BoolValue(resp.Status.Resources.EnableCPUPassthrough))
 	d.Set("num_vnuma_nodes", utils.Int64Value(resp.Status.Resources.VnumaConfig.NumVnumaNodes))
 	d.Set("guest_os_id", utils.StringValue(resp.Status.Resources.GuestOsID))
 	d.Set("power_state", utils.StringValue(resp.Status.Resources.PowerState))
@@ -999,7 +1003,10 @@ func resourceNutanixDatasourceVirtualMachineInstanceResourceV0() *schema.Resourc
 			},
 
 			// RESOURCES ARGUMENTS
-
+			"enable_cpu_passthrough": {
+				Type:     schema.TypeBool,
+				Computed: true,
+			},
 			"num_vnuma_nodes": {
 				Type:     schema.TypeInt,
 				Computed: true,

diff --git a/nutanix/resource_nutanix_virtual_machine.go b/nutanix/resource_nutanix_virtual_machine.go
@@ -286,6 +286,11 @@ func resourceNutanixVirtualMachine() *schema.Resource {
 
 			// RESOURCES ARGUMENTS
 
+			"enable_cpu_passthrough": {
+				Type:     schema.TypeBool,
+				Optional: true,
+				Default:  false,
+			},
 			"use_hot_add": {
 				Type:     schema.TypeBool,
 				Optional: true,
@@ -1077,6 +1082,7 @@ func resourceNutanixVirtualMachineRead(d *schema.ResourceData, meta interface{})
 		return fmt.Errorf("error setting guest_customization_sysprep for Virtual Machine %s: %s", d.Id(), err)
 	}
 
+	d.Set("enable_cpu_passthrough", resp.Status.Resources.EnableCPUPassthrough)
 	d.Set("guest_customization_cloud_init_user_data", cloudInitUser)
 	d.Set("guest_customization_cloud_init_meta_data", cloudInitMeta)
 	d.Set("hardware_clock_timezone", utils.StringValue(resp.Status.Resources.HardwareClockTimezone))
@@ -1183,6 +1189,12 @@ func resourceNutanixVirtualMachineUpdate(d *schema.ResourceData, meta interface{
 		res.ParentReference = validateRef(n.(map[string]interface{}))
 		hotPlugChange = false
 	}
+	if d.HasChange("enable_cpu_passthrough") {
+		_, n := d.GetChange("enable_cpu_passthrough")
+		res.EnableCPUPassthrough = utils.BoolPtr(n.(bool))
+		// TODO: Is this correct?
+		hotPlugChange = false
+	}
 	if d.HasChange("num_vnuma_nodes") {
 		_, n := d.GetChange("num_vnuma_nodes")
 		res.VMVnumaConfig = &v3.VMVnumaConfig{
@@ -1630,6 +1642,9 @@ func getVMResources(d *schema.ResourceData, vm *v3.VMResources) error {
 	if v, ok := d.GetOk("num_vcpus_per_socket"); ok {
 		vm.NumVcpusPerSocket = utils.Int64Ptr(int64(v.(int)))
 	}
+	if v, ok := d.GetOk("enable_cpu_passthrough"); ok {
+		vm.EnableCPUPassthrough = utils.BoolPtr(v.(bool))
+	}
 	if v, ok := d.GetOk("num_sockets"); ok {
 		vm.NumSockets = utils.Int64Ptr(int64(v.(int)))
 	}
@@ -2428,6 +2443,11 @@ func resourceNutanixVirtualMachineInstanceResourceV0() *schema.Resource {
 
 			// RESOURCES ARGUMENTS
 
+			"enable_cpu_passthrough": {
+				Type:     schema.TypeBool,
+				Optional: true,
+				Default:  false,
+			},
 			"num_vnuma_nodes": {
 				Type:     schema.TypeInt,
 				Optional: true,