refactor: add new kube-proxy mode disable option #1319
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimmidyson
reviewed
Sep 25, 2025
jimmidyson
approved these changes
Sep 25, 2025
supershal
reviewed
Sep 26, 2025
pkg/handlers/generic/lifecycle/cni/cilium/handler_integration_test.go
Outdated
Show resolved
Hide resolved
supershal
approved these changes
Sep 26, 2025
supershal
reviewed
Sep 26, 2025
supershal
reviewed
Sep 26, 2025
dkoshkin
force-pushed
the
dkoshkin/refactor-kube-proxy-mode-disable-option
branch
from
26f238f to
a8b63d3
Compare
supershal
approved these changes
Sep 26, 2025
dkoshkin
deleted the
dkoshkin/refactor-kube-proxy-mode-disable-option
branch
Merged
vijayaraghavanr31
pushed a commit
that referenced
this pull request
Oct 8, 2025
**What problem does this PR solve?**:
Moves the annotation based way of disabling kube-proxy to be driven by
CAREN API instead.
```
apiVersion: cluster.x-k8s.io/v1beta1
kind: Cluster
metadata:
name: <NAME>
spec:
topology:
variables:
- name: clusterConfig
value:
kubeProxy:
mode: disabled
```
**Which issue(s) this PR fixes**:
Fixes #
**How Has This Been Tested?**:
<!--
Please describe the tests that you ran to verify your changes.
Provide output from the tests and any manual steps needed to replicate
the tests.
-->
**Special notes for your reviewer**:
<!--
Use this to provide any additional information to the reviewers.
This may include:
- Best way to review the PR.
- Where the author wants the most review attention on.
- etc.
-->
This was referenced Oct 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?:
Moves the annotation based way of disabling kube-proxy to be driven by CAREN API instead.
Which issue(s) this PR fixes:
Fixes #
How Has This Been Tested?:
Special notes for your reviewer: