feat: add volume APIs to AWS and EKS Nodes #1309
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimmidyson
reviewed
Sep 18, 2025
dkoshkin
force-pushed
the
dkoshkin/feat-aws-eks-rootvolume
branch
3 times, most recently
from
47a0d9e to
5b4e789
Compare
jimmidyson
reviewed
Sep 19, 2025
dkoshkin
changed the title
This reverts commit b02fa6e.
dkoshkin
force-pushed
the
dkoshkin/feat-aws-eks-rootvolume
branch
from
08d7826 to
e21d6f8
Compare
jimmidyson
approved these changes
Sep 23, 2025
faiq
approved these changes
Sep 24, 2025
vijayaraghavanr31
pushed a commit
that referenced
this pull request
Oct 8, 2025
**What problem does this PR solve?**: Exposes CAPA's [rootVolume](https://github.com/kubernetes-sigs/cluster-api-provider-aws/blob/88cb4b92b1a76591623e9d5ef347bfdc22010622/api/v1beta1/types.go#L184) and [nonRootVolumes](https://github.com/kubernetes-sigs/cluster-api-provider-aws/blob/88cb4b92b1a76591623e9d5ef347bfdc22010622/api/v1beta1/types.go#L188C33-L188C47) APIs in CAREN API. I did not use the capav1.Volume type directly so that we can have proper kubebuilder annotations and used basic types instead of pointers that the CAPA uses (inconsistently). **Which issue(s) this PR fixes**: Fixes # **How Has This Been Tested?**: <!-- Please describe the tests that you ran to verify your changes. Provide output from the tests and any manual steps needed to replicate the tests. --> Unit tests and also created an EKS cluster with 2 Nodepools Defaults with default root volume <img width="1433" height="179" alt="image" src="https://github.com/user-attachments/assets/2d6259ea-c553-432a-b8b9-cc6b6c7c714e" /> Second nodepool with a modified root and additional volume <img width="1429" height="209" alt="image" src="https://github.com/user-attachments/assets/f6ff7f41-fae4-4ffa-aaa4-ce3282bc6ed4" /> **Special notes for your reviewer**: <!-- Use this to provide any additional information to the reviewers. This may include: - Best way to review the PR. - Where the author wants the most review attention on. - etc. -->
This was referenced Oct 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?:
Exposes CAPA's rootVolume and nonRootVolumes APIs in CAREN API.
I did not use the capav1.Volume type directly so that we can have proper kubebuilder annotations and used basic types instead of pointers that the CAPA uses (inconsistently).
Which issue(s) this PR fixes:
Fixes #
How Has This Been Tested?:
Unit tests and also created an EKS cluster with 2 Nodepools
Defaults with default root volume
Second nodepool with a modified root and additional volume
Special notes for your reviewer: