feat: Enable configurable parallel image pulls #1306
Conversation
jimmidyson
requested review from
dkoshkin,
supershal,
thunderboltsid and
yannickstruyf3
There was a problem hiding this comment.
If the default value of "maxParallelImagePullsPerNode" is set to 1, it is equivalent to enabling the serializeImagePulls. Do we want the default behavior of this to be the same as before (using serializeImagePulls), or set a reasonable default value (such as 5) to use parallel image pulling?
@jimmidyson replied: I think this is good. |
pkg/handlers/generic/mutation/parallelimagepulls/embedded/kubeletconfigpatch.yaml
Outdated
Show resolved
Hide resolved
jimmidyson
force-pushed
the
jimmi/parallel-image-pulls
branch
from
7bc8d8c to
e026124
Compare
Default behaviour is retained, that is serialized image pulls actually configured by disabling forced serialized image pulls and setting max parallel image pulls to 1. A value of zero means unlimited parallel image pulls.
jimmidyson
force-pushed
the
jimmi/parallel-image-pulls
branch
from
af5ddf9 to
04440e8
Compare
**What problem does this PR solve?**: Default behaviour is retained, that is serialized image pulls actually configured by disabling forced serialized image pulls and setting max parallel image pulls to 1. A value of zero means unlimited parallel image pulls. **Which issue(s) this PR fixes**: Fixes # **How Has This Been Tested?**: <!-- Please describe the tests that you ran to verify your changes. Provide output from the tests and any manual steps needed to replicate the tests. --> **Special notes for your reviewer**: <!-- Use this to provide any additional information to the reviewers. This may include: - Best way to review the PR. - Where the author wants the most review attention on. - etc. -->
What problem does this PR solve?:
Default behaviour is retained, that is serialized image pulls actually configured by disabling forced serialized image pulls and setting max parallel image pulls to 1.
A value of zero means unlimited parallel image pulls.
Which issue(s) this PR fixes:
Fixes #
How Has This Been Tested?:
Special notes for your reviewer: