feat: EKS ClusterClass and Cluster example #1255
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimmidyson
force-pushed
the
jimmi/eks-cc-cluster
branch
3 times, most recently
from
0493d80 to
e5c6d6f
Compare
jimmidyson
force-pushed
the
jimmi/eks-handlers
branch
2 times, most recently
from
c06c78a to
b3e2485
Compare
jimmidyson
force-pushed
the
jimmi/eks-cc-cluster
branch
from
cde43ae to
33a45c1
Compare
jimmidyson
force-pushed
the
jimmi/eks-handlers
branch
from
b3e2485 to
3de1474
Compare
jimmidyson
force-pushed
the
jimmi/eks-cc-cluster
branch
from
33a45c1 to
e6e1f4a
Compare
dkoshkin
previously approved these changes
Aug 13, 2025
| --addon helm:$(CAAPH_VERSION) \ | ||
| --wait-providers | ||
| kubectl apply --server-side --force-conflicts \ | ||
| kubectl --kubeconfig=$(KIND_KUBECONFIG) apply --server-side --force-conflicts \ |
There was a problem hiding this comment.
How did this work before 🤔 It didn't this was added in a different new PR
jimmidyson
force-pushed
the
jimmi/eks-cc-cluster
branch
from
e17fac0 to
0aeb0ce
Compare
Reusing as much as possible of the AWS handlers, with slight tweaks.
jimmidyson
force-pushed
the
jimmi/eks-handlers
branch
from
f754dfa to
c5dd8df
Compare
Currently the metamutator only passes the override values when they are present on a machine deployment or control plane config. This commit fixes that by merging the global variables into the overrides, resulting in the behaviour that we always expected. As overrides are not that commonly used yet, we have not seen this issue but as taints, etc become more commonly used this will become an issue. Tests added to prove the fix as well.
The bases are included in the hack directory rather than pulling in from external projects as we do for other providers because the EKS CC support has not been released in CAPA yet. Once that has happened, we can switch to the same strategy and use the upstream CC and Cluster as the base for patching to create the CAREN CC/Cluster examples.
This was breaking certain pod deployments due to incorrect IAM permissions.
jimmidyson
force-pushed
the
jimmi/eks-cc-cluster
branch
from
0aeb0ce to
56a3f5b
Compare
jimmidyson
force-pushed
the
jimmi/eks-handlers
branch
2 times, most recently
from
b767bf4 to
b953a65
Compare
jimmidyson
force-pushed
the
jimmi/eks-handlers
branch
from
8db0708 to
45616e7
Compare
dkoshkin
added a commit
that referenced
this pull request
Sep 16, 2025
**What problem does this PR solve?**: Adding a ClusterClass and an example file for EKS clusters. Based on #1255, 1. with minor changes to fixup after more recent changes 2. change to not rely on #1252 3. minor refactoring in kustomize to align better with the other examples **Which issue(s) this PR fixes**: Fixes # **How Has This Been Tested?**: <!-- Please describe the tests that you ran to verify your changes. Provide output from the tests and any manual steps needed to replicate the tests. --> **Special notes for your reviewer**: <!-- Use this to provide any additional information to the reviewers. This may include: - Best way to review the PR. - Where the author wants the most review attention on. - etc. --> --------- Co-authored-by: Jimmi Dyson <jimmidyson@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?:
Which issue(s) this PR fixes:
Fixes #
How Has This Been Tested?:
Special notes for your reviewer:
The bases are included in the hack directory rather than pulling in from external projects as we do for other providers because the EKS CC support has not been released in CAPA yet. Once that has happened, we can switch to the same strategy and use the upstream CC and Cluster as the base for patching to create the CAREN CC/Cluster examples.
Requires #1254 and #1252.