This repository was archived by the owner on Oct 18, 2023. It is now read-only.
fix: resolve opencv version when running under npm 7 #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
npm 7 removes the npm_package_* environment variables, so the version needs to be obtained by
requiring the package.json and pulling from that
This also add --no-save to the npm install command so that the package isn't added to the top level
package.json
Closes #9
|
Hi @ewanharris 👋 Thanks for your contributions! Best regards Simon |
goretkin
added a commit
to goretkin/LoggingPlayground
that referenced
this pull request
Mar 6, 2021
`vscode-extension-tester` has an indirect dependency on https://www.npmjs.com/package/opencv4nodejs-prebuilt (via https://github.com/nut-tree) which has an issue on npm@7 https://github.com/nut-tree/opencv4nodejs/issues/9 That issue might be resolved here: nut-tree/opencv4nodejs#10 which hasn't been released.
goretkin
added a commit
to goretkin/LoggingPlayground
that referenced
this pull request
Mar 6, 2021
gh pr checkout nut-tree/opencv4nodejs#10
s1hofmann
approved these changes
Apr 5, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
npm 7 removes the npm_package_* environment variables, so the version needs to be obtained by
requiring the package.json and pulling from that
This also add --no-save to the npm install command so that the package isn't added to the top level
package.json
Closes #9