Fix TextMate regex #137
Merged
Fix TextMate regex #137
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I'm not sure this is working right. Here is I'm struggling to find something that will test the other changes. |
Contributor
Author
|
Argh yeah, that was the issue I was trying to avoid in command... I have to do something so |
It surely has been useful in early stage of the syntax but it's seems to have no impact now
get rid of non-fixed text width lookbehind, incompatible with PCRE regex
variable can have 0 or more fields
Contributor
Author
|
okay, i just fix the issue Tell me if you find something wrong 👍 |
Contributor
|
I looked it over and tested it out. Nothing else seems to jump out. I did find a new issue though unrelated to this PR. #139 |
Contributor
|
Thanks for all your help! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From hustcer/nu-grammar#1
Remove non-fixed text width in lookbehind and negative lookahead regex.
Note: about "command" rule regex, i didn't remember why I wrote
|(?<=\\)|\\}|\\]|\\$\\w+)\\.in "command" rule. I think it was useful in early stage of making this file.Anyway, I didn't see any case where it is useful now. I tried different files to see if it causes any issue if I remove it, but I didn't see any.
So if someone see something wrong in the future, let me now 👍