vi-mode: add gg/G motions and fix ^ motion behavior by Juhan280 · Pull Request #953 · nushell/reedline

Juhan280 · 2025-09-21T14:53:05Z

This PR adds the gg and G motions and adjusts the ^ motion in vi-mode. The gg motion moves the cursor to the first character of the buffer and G moves it to the last. Unlike Vim, G takes the cursor to the end of the buffer instead of the first character of the last line. Tests are included for dgg, dG, cgg, and cG.

The ^ motion now moves the cursor to the first non-blank character of the line instead of the line start. Test cases for d^ and c^ are updated accordingly.

Also, the name NonBlankStart could be better. Please tell me if you come up with something better.

This is the first pr I made in rust, if I did any mistake please point it out. Thanks

ysthakur

I have very little experience with both Reedline keybindings and Vim, so pardon my ignorance.

Unlike Vim, these motions do not keep the current column

I just tried them out in Vim, and both of them seem to go to the first column rather than keeping the current column. I checked my ~/.vimrc and I do have custom keybindings for some reason, but none that would affect gg/G.

their interaction with commands like c, d, and y differs because reedline does not support linewise operations

Could you give an example of where behavior would differ from Vim? For cgg, dgg, and ygg, at least, it seems to be working fine, entire lines get cut/deleted/yanked.

For G, though, I'd like to verify that Vim doesn't go to the first column. Because if it does, the implementation in this PR doesn't match.

In the future, I'd recommend splitting up PRs that do multiple things (here, adding gg and G is one feature, and fixing ^ is a related but separate thing). Not a big deal, especially since it's such a small change here.

src/core_editor/editor.rs

Juhan280 · 2026-01-13T07:31:35Z

I have very little experience with both Reedline keybindings and Vim, so pardon my ignorance.

Unlike Vim, these motions do not keep the current column

I just tried them out in Vim, and both of them seem to go to the first column rather than keeping the current column. I checked my ~/.vimrc and I do have custom keybindings for some reason, but none that would affect gg/G.

I will be honest, I didn't test against vim but rather neovim. And I assumed the behaviour would be the same. But you are right, in vim, the cursor always goes to the first character of the line.

their interaction with commands like c, d, and y differs because reedline does not support linewise operations

Could you give an example of where behavior would differ from Vim? For cgg, dgg, and ygg, at least, it seems to be working fine, entire lines get cut/deleted/yanked.

If we have this

aaa
xxx
yyy

and perform this set of motion ggjdGggp, the text will look identical in vim, but in reedline it will look like this

a
xxx
yyyaa

It is because, if you copy something linewise in vim, it will also paste linewise i.e. it won't paste it between two characters of a line.
Edit: I was going through the source code again, and then discovered reedline actually support linewise copy. I will update my code to use it.

For G, though, I'd like to verify that Vim doesn't go to the first column. Because if it does, the implementation in this PR doesn't match.

Yes, this is where I intentionally make it different. In a commandline context, needing to go at the absolute end of the buffer is more frequent. You can go the the first character of the line using G0. In vi mode of fish shell, G also takes the cursor to the absolute end of the buffer.

In the future, I'd recommend splitting up PRs that do multiple things (here, adding gg and G is one feature, and fixing ^ is a related but separate thing). Not a big deal, especially since it's such a small change here.

Understood. If you ask me, I can try to split this PR. I already made separate commits for them.

src/core_editor/editor.rs

Juhan280

I have updated to code to use linewise copy

ysthakur · 2026-01-15T01:48:45Z

It is because, if you copy something linewise in vim, it will also paste linewise i.e. it won't paste it between two characters of a line. Edit: I was going through the source code again, and then discovered reedline actually support linewise copy. I will update my code to use it.

Great! Thanks for the explanation before the edit.

For G, though, I'd like to verify that Vim doesn't go to the first column. Because if it does, the implementation in this PR doesn't match.

Yes, this is where I intentionally make it different. In a commandline context, needing to go at the absolute end of the buffer is more frequent. You can go the the first character of the line using G0. In vi mode of fish shell, G also takes the cursor to the absolute end of the buffer.

Makes sense

Understood. If you ask me, I can try to split this PR. I already made separate commits for them.

Nah, you're good. This is a fairly small PR anyway.

src/edit_mode/vi/parser.rs

There is a bit of divergence in behaviour of `G` motion of reedline and vim. In vim, `G` takes the cursor to the first character of the last line. In reedline, it tales to the very last character of the buffer instead. Also when using these motion with a command, e.g. `c`, `d` and `y`, there are some inconsistency in handling the new line character. Added test case for `dgg`, `dG`, `cgg` and `cG` command.

Previously the `^` motion was behaving like the `0` motion which is to move the cursor to the start of the line. But in vim, the `^` motion is different from `0` motion. In vim `^` moved the cursor to the first non-blank character of the line. (See `:h ^`) Updated test case for `d^` and `c^` command since it has different behaviour now.

ysthakur · 2026-01-16T02:55:33Z

When you make changes, could you please upload the changes as separate commits, rather than rebasing and force pushing? When you force push, I can't tell what changed since the last time I reviewed the PR. However, if you make a new commit, GitHub will show me the new changes (or I can look at the new commits myself).

If you're maintaining the change as 2 separate commits to keep the commit history clean, you don't need to worry about that. We always squash and merge PRs, so no matter how many commits you make, it'll all turn into a single commit when merging anyway.

Juhan280 · 2026-01-16T13:08:12Z

When you make changes, could you please upload the changes as separate commits, rather than rebasing and force pushing? When you force push, I can't tell what changed since the last time I reviewed the PR. However, if you make a new commit, GitHub will show me the new changes (or I can look at the new commits myself).

Okay

If you're maintaining the change as 2 separate commits to keep the commit history clean, you don't need to worry about that. We always squash and merge PRs, so no matter how many commits you make, it'll all turn into a single commit when merging anyway.

Yeah, I was trying to keep commit history clean

src/enums.rs

src/core_editor/editor.rs

ysthakur

Just tried out your latest commit and it does work, just got a couple of minor suggestions and then we should be good to merge

Although I am not sure if this is a good idea

Juhan280 · 2026-02-06T09:05:08Z

@ysthakur Is there anything else that need change?

Also are we okay with the name NonBlankStart

Juhan280 · 2026-02-06T15:17:56Z

Also are we sure the value of CutFromStartLinewise and CutToEndLinewise should be required. Or should it be optional? If so, what should be the default?

ysthakur · 2026-02-07T23:09:25Z

Also are we okay with the name NonBlankStart

Sounds fine to me

Also are we sure the value of CutFromStartLinewise and CutToEndLinewise should be required. Or should it be optional? If so, what should be the default?

Making it required seems best to me. Might be slightly more annoying, but I don't think either true or false is clearly the better default

Juhan280 force-pushed the vi-mode branch 6 times, most recently from 0bcc73d to eedb81a Compare October 2, 2025 12:43

Juhan280 mentioned this pull request Jan 8, 2026

Cursor position after up arrow history cycling is unconventional on multi-line statements #999

Open

ysthakur added A-ViKeybinding Area: Vi(m) keybinding support enhancement New feature or request labels Jan 9, 2026

ysthakur self-requested a review January 9, 2026 06:45

ysthakur reviewed Jan 13, 2026

View reviewed changes

src/core_editor/editor.rs Outdated Show resolved Hide resolved

Juhan280 force-pushed the vi-mode branch 2 times, most recently from 1c275de to 9bc868b Compare January 14, 2026 10:34

Juhan280 commented Jan 14, 2026

View reviewed changes

src/core_editor/editor.rs Outdated Show resolved Hide resolved

Juhan280 commented Jan 14, 2026

View reviewed changes

Juhan280 force-pushed the vi-mode branch 2 times, most recently from 73e850d to 81526b0 Compare January 14, 2026 13:01

ysthakur reviewed Jan 15, 2026

View reviewed changes

src/edit_mode/vi/parser.rs Show resolved Hide resolved

Juhan280 force-pushed the vi-mode branch from 81526b0 to 34ec19a Compare January 15, 2026 11:34

Juhan280 added 2 commits January 15, 2026 18:13

Juhan280 force-pushed the vi-mode branch from 34ec19a to 696150a Compare January 15, 2026 12:16

make dgg and dG not leave empty line

237f758

Juhan280 commented Jan 16, 2026

View reviewed changes

src/enums.rs Outdated Show resolved Hide resolved

Juhan280 requested a review from ysthakur January 27, 2026 05:37

ysthakur reviewed Jan 29, 2026

View reviewed changes

src/core_editor/editor.rs Outdated Show resolved Hide resolved

ysthakur requested changes Jan 29, 2026

View reviewed changes

Juhan280 added 3 commits January 29, 2026 13:08

use if expressions instead of converting bool to usize

135b5b0

rename leave_blank_line to Value in the Display impl for EditCommand

d028e14

Although I am not sure if this is a good idea

Merge branch 'main' into vi-mode

0c63349

ysthakur merged commit 40d8da1 into nushell:main Feb 7, 2026
6 checks passed

ysthakur mentioned this pull request Feb 7, 2026

feat: add linewise and non-blank start edit commands nushell/nushell#17508

Merged

1 task

Juhan280 deleted the vi-mode branch February 7, 2026 23:23

Comments

Conversation

Juhan280 commented Sep 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

This is the first pr I made in rust, if I did any mistake please point it out. Thanks

Uh oh!

ysthakur left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Juhan280 commented Jan 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Juhan280 left a comment

Choose a reason for hiding this comment

Uh oh!

ysthakur commented Jan 15, 2026

Uh oh!

Uh oh!

ysthakur commented Jan 16, 2026

Uh oh!

Juhan280 commented Jan 16, 2026

Uh oh!

Uh oh!

Uh oh!

ysthakur left a comment

Choose a reason for hiding this comment

Uh oh!

Juhan280 commented Feb 6, 2026

Uh oh!

Juhan280 commented Feb 6, 2026

Uh oh!

ysthakur commented Feb 7, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Juhan280 commented Sep 21, 2025 •

edited

Loading

Juhan280 commented Jan 13, 2026 •

edited

Loading