Further cleanup of Span::test_data
usage + span fixes
#7595
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Inspired by #7592
For brevity use
Value::test_{string,int,float,bool}
Includes fixes to commands that were abusing
Span::test_data
in their implementation. Now the call span is used where possible or the explicitSpan::unknonw
is used.Command fixes
Span::test_data()
inquery_xml
Span::test_data()
interm size
Span::test_data()
inseq date
Span::test_data
innu-cli
Span::test_data
toSpan::unknown
inkeybindings listen
registry query
nu_plugin_query
select
Span::unknown
instead oftest_data
in more placesOther
Value::test_int
/test_float()
consistentlytest_string
andtest_bool
User-Facing Changes
Some commands may now provide more helpful spans for downstream use in errors