Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Further cleanup of Span::test_data usage + span fixes #7595

Merged
merged 12 commits into from
Dec 24, 2022

Conversation

sholderbach
Copy link
Member

Description

Inspired by #7592

For brevity use Value::test_{string,int,float,bool}

Includes fixes to commands that were abusing Span::test_data in their implementation. Now the call span is used where possible or the explicit Span::unknonw is used.

Command fixes

  • Fix abuse of Span::test_data() in query_xml
  • Fix abuse of Span::test_data() in term size
  • Fix abuse of Span::test_data() in seq date
  • Fix two abuses of Span::test_data in nu-cli
  • Change Span::test_data to Span::unknown in keybindings listen
  • Add proper call span to registry query
  • Fix span use in nu_plugin_query
  • Fix span assignment in select
  • Use Span::unknown instead of test_data in more places

Other

  • Use Value::test_int/test_float() consistently
  • More test_string and test_bool
  • Fix unused imports

User-Facing Changes

Some commands may now provide more helpful spans for downstream use in errors

@fdncred
Copy link
Collaborator

fdncred commented Dec 24, 2022

wow! lots more cleanup. good work!

@fdncred fdncred merged commit 45fe3be into nushell:main Dec 24, 2022
@sholderbach sholderbach deleted the test-span-usage branch December 24, 2022 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants