CLI now accepts strings as stdin#15
Merged
Merged
Conversation
Contributor
|
Looking good! Thanks again! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Finally I modified
clapto accept either a file or a string.It came with a couple of architectural changes:
Sessionstruct, because it wasn't really relevant to have it.Inputwas also a rock the way to interpret files to format. So also it was deleted for better code readabilityformat_single_fileandformat_stringthat redirects the code toformat_inner, where the code is formatted. The first 2 functions have the responsibility of reading & writing the file, or writing to stdout respectably.