Skip to content

fishgen: Fix conflicting flag column names #1119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Kissaki
Copy link
Contributor

@Kissaki Kissaki commented May 11, 2025

'c' and 'C' conflicted, leading to get c getting the C column

Clear out 'complete ' earlier, in tokenize-complete-lines.

Parse and pair flags without values as well.


Based on #1122

@Kissaki
Copy link
Contributor Author

Kissaki commented May 11, 2025

I have four commits but don't want to lose the distinct history of the changes by squash merges. Handling these as separate PRs is a hassle. Isn't merging with merge commit something that could be done where it makes sense?

I'm used to structuring my commits into a descriptive history, and sectioning bigger changes step by step, where each step makes sense on its own. The PR title and description then becomes the merge commit, and describes the whole set of changes.

@Kissaki Kissaki changed the title Drop unnecessary line length check fishgen: Drop unnecessary line length check May 11, 2025
@Kissaki Kissaki changed the title fishgen: Drop unnecessary line length check fishgen: Fix conflicting flag column names May 11, 2025
@fdncred
Copy link
Contributor

fdncred commented May 11, 2025

Doing your commits this way is helpful to reviewers but we squash and merge in all of our repos.

@Kissaki
Copy link
Contributor Author

Kissaki commented May 11, 2025

is rebased with "conflict" resolved

Kissaki added 2 commits May 11, 2025 19:26
'c' and 'C' conflicted, leading to get c getting the C column

Clear out 'complete ' earlier, in tokenize-complete-lines.

Parse and pair flags without values as well.
@Kissaki Kissaki marked this pull request as draft May 11, 2025 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants