Android streams implementation #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| StreamRefreshListFragment fragment = new StreamRefreshListFragment(); | ||
| Bundle args = new Bundle(); | ||
| args.putInt(ARG_SECTION_NUMBER, sectionNumber); | ||
| fragment.setArguments(args); | ||
| fragment.sectionNumber = sectionNumber; | ||
| fragment.sectionNumber = sectionNumber; |
There was a problem hiding this comment.
I think there's a copy paste error?
There was a problem hiding this comment.
The duplicate error is still present
|
Done the review. You can look at the comments. |
|
@kylelwm I think the changes haven't been pushed. |
New changes to original pull requestChangelog1. Removed GIF player and use WebView to play GIF background instead2. Fix bug with pressing back button in main screen returning user to login screen3. Set up basic testing environment for Android client4. Wrote simple redirection tests for Android classes5. Updated JavaCV version and added filter for video to fix rotation issue6. Refactor and created several new fragments for streamer- Created a fragment for stream creation and termination- Created a fragment for stream controls- Created a fragment for actual streaming7. Added API end point for creating stream8. Redirect user to view screen when a stream is selected9. Refactor WorldScopeStream objects to be parcelable |
kylelwm
force-pushed
the
android-streams-implementation
branch
from
1dc0147 to
9752cb1
Compare
… usages to reflect the change
…ms and test getting stream in putFakeData()
…ayed on top of the preview
…ts instead of just streaming videos
…elements for confirmation
…l video streaming
…n during streaming
…can be passed as Intent extra
…ry to format time
kylelwm
force-pushed
the
android-streams-implementation
branch
from
9752cb1 to
11b722c
Compare
|
Please review =) |
|
Ok, good to proceed. |
kylelwm
added a commit
that referenced
this pull request
Feb 16, 2016
Android streams implementation
|
Merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created model folder with all model data inside
Implemented logout
Setup swipeRefreshLayout to list view for Android
Call and get stream data from server