Skip to content

Add "Pause/play on double click" option #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add "Pause/play on double click" option #116

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 32 additions & 1 deletion src/pause_click.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,9 @@ static const int mouse_button_values[] = {-1, MOUSE_BUTTON_LEFT, MOUSE_BUTTON_CE
#define MOUSE_BUTTON_CFG CFG_PREFIX "mouse-button"
#define MOUSE_BUTTON_DEFAULT 1 // MOUSE_BUTTON_LEFT

#define PAUSE_ON_DOUBLE_CLICK_CFG CFG_PREFIX "pause-on-double-click"
#define PAUSE_ON_DOUBLE_CLICK_DEFAULT false

#define DOUBLE_CLICK_DELAY_CFG CFG_PREFIX "double-click-delay"
#define DOUBLE_CLICK_DELAY_DEFAULT 300

Expand Down Expand Up @@ -183,6 +186,10 @@ vlc_module_begin()
N_("Overlay pause and play icons on the video when it's paused and "
"played respectively."), false)
set_section(N_("Double click behavior"), NULL)
_add_bool(PAUSE_ON_DOUBLE_CLICK_CFG, PAUSE_ON_DOUBLE_CLICK_DEFAULT,
N_("Pause/play on double click"),
N_("When enabled, double click will pause/play the video instead of single click. "
"This will automatically disable fullscreen toggle on double click."), false)
_add_bool(ENABLE_DOUBLE_CLICK_DELAY_CFG, ENABLE_DOUBLE_CLICK_DELAY_DEFAULT,
N_("Enable the custom double click interval"),
N_("Ignore system's double click interval and use our own instead. "
Expand Down Expand Up @@ -487,6 +494,7 @@ static int mouse(filter_t *p_filter, vlc_mouse_t *p_mouse_out, const vlc_mouse_t
// get mouse button from settings. updates if user changes the setting
const int mouse_button = cfg_get_mouse_button((vlc_object_t *)p_filter, MOUSE_BUTTON_CFG, MOUSE_BUTTON_DEFAULT);
msg_Dbg(p_filter, "mouse_button=%d", mouse_button);
const bool pause_on_double_click = var_InheritBool(p_filter, PAUSE_ON_DOUBLE_CLICK_CFG);

// manually control double click to fullscreen if directly requested or if the ignore double click option is set
if ((var_InheritBool(p_filter, ENABLE_DOUBLE_CLICK_DELAY_CFG) || var_InheritBool(p_filter, IGNORE_DOUBLE_CLICK_CFG)) &&
Expand All @@ -495,8 +503,21 @@ static int mouse(filter_t *p_filter, vlc_mouse_t *p_mouse_out, const vlc_mouse_t
p_mouse_out->b_double_click = 0;
}

if (pause_on_double_click) {
// pause or play on double click
if (p_mouse_new->b_double_click && mouse_button == MOUSE_BUTTON_LEFT) {
pause_play();
// disable fullscreen toggle on double click
p_mouse_out->b_double_click = 0;
}
// ignore single clicks if double click is enabled
else if (vlc_mouse_HasPressed(p_mouse_old, p_mouse_new, mouse_button)) {
// do nothing
}
}

// react only on the configured mouse button click
if (vlc_mouse_HasPressed(p_mouse_old, p_mouse_new, mouse_button)
else if (vlc_mouse_HasPressed(p_mouse_old, p_mouse_new, mouse_button)
#if LIBVLC_VERSION_MAJOR <= 3
// treat the double click as the left mouse button click
|| (p_mouse_new->b_double_click && mouse_button == MOUSE_BUTTON_LEFT)
Expand Down Expand Up @@ -606,6 +627,16 @@ static int OpenFilter(vlc_object_t *p_this)
"Don't forget to restart VLC afterwards");
return VLC_EGENERIC;
}

if (var_InheritBool(p_filter, PAUSE_ON_DOUBLE_CLICK_CFG)) {
// disable ignore double click
config_PutInt(p_filter, IGNORE_DOUBLE_CLICK_CFG, false);
// disable fullscreen toggle on double click
config_PutInt(p_filter, DISABLE_FS_TOGGLE_CFG, true);

msg_Dbg(p_filter, "Pause on double click enabled - auto-configuring related options");
}

video_format_Print(p_this, "pause_click FORMAT IN:", &p_filter->fmt_in.video);
video_format_Print(p_this, "pause_click FORMAT OUT:", &p_filter->fmt_out.video);
msg_Dbg(p_filter, "b_allow_fmt_out_change=%d", p_filter->b_allow_fmt_out_change);
Expand Down