This repository has been archived by the owner on Jun 11, 2020. It is now read-only.
Added mutli-select feature in friendlist #109
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/friendswidget.cpp
Outdated
| { | ||
| int friendId; | ||
| QStandardItem *friendItem; | ||
| foreach (QModelIndex selectedIndex, friendView->selectionModel()->selectedIndexes()) |
There was a problem hiding this comment.
Use C++11's foreach loop over Qt's foreach. In that case you can even use
for (const QModelIndex& selectedIndex : friendView->selectionModel()->selectedIndexes()) {Also, your for-loop shouldn't have the opening brace on the next line.
|
I guess it's a little harder that I thought, since we don't want a multi-select on item drag, which is the default behavior. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
Tox-Qt-GUIdoesn't have multi-select support in thefriendsWidget. With this patch, users will be able to select multiple friends and remove them.