Skip to content
This repository has been archived by the owner on Jun 11, 2020. It is now read-only.

Reimplement Message Display widget #62

Closed
nurupo opened this issue Oct 15, 2013 · 4 comments
Closed

Reimplement Message Display widget #62

nurupo opened this issue Oct 15, 2013 · 4 comments

Comments

@nurupo
Copy link
Owner

nurupo commented Oct 15, 2013

Discussed in #60

In short, current implementation of the Message Display consumes too much memory and requires a lot of cpu time for processing, which freezes GUI for seconds, as number of messages grows. That's definitely something undesired, so we need to change the implementation of it.
It was decided to use Quassel's QGraphicsView-based Message Display implementation which has better performance.
Use of QTextEdit for Message Display was rejected in favor of benefits Quassel's solution has.

Schlumpf said that he will take a look into this after finishing working on new Friend Request widget.

@Schlumpf
Copy link
Contributor

Short update from new messages widget: Basic Quassel-like chat works :)
But now I have do change several things to implement smileys.

@nurupo
Copy link
Owner Author

nurupo commented Feb 20, 2014

Sounds great!

Could you explain how are you going to add smiley support, what will you change in original implementation?

@Schlumpf
Copy link
Contributor

Currently the text rendering is done by hand. That's mean, Quassel calculetes the line braking and paints these lines by QTextLayout. This approach doesn't allow painting anything else than text, text with formatting is possible, but only text. The text selecting and rendering is done by hand, too.

Now I try to replace the manual text layouting by QTextDocument, which supports images. QTextDocument would do the line braking and layouting formated text and images. It's a bit tricky to paint a QTextDocument without using the QTextEdit widget, that's what I doing currently.

@nurupo
Copy link
Owner Author

nurupo commented May 31, 2014

Closing the issue, Quassel-like message view got merged in.

@nurupo nurupo closed this as completed May 31, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants