Implement Compose Navigation Safe Args #31
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit refactors the navigation within the application to use Compose Navigation Safe Args. Key changes include: - Defined sealed class objects for navigation destinations (Login, Profile, Goal, etc.) to improve type safety. - Updated `LeetCodePlusNavGraph` to use the new sealed class destinations and the `toRoute` extension function for argument handling in the WebView screen. - Modified `LeetCodePlusNavigation` to accept and navigate using the sealed class objects. - Added the `kotlinx.serialization.json` dependency and the corresponding Kotlin serialization plugin for handling navigation arguments. - Removed the unused `caller` parameter from the `WebViewScreen` composable.
# Conflicts: # app/src/main/kotlin/com/byteutility/dev/leetcode/plus/ui/navigation/LeetCodePlusNavGraph.kt # app/src/main/kotlin/com/byteutility/dev/leetcode/plus/ui/navigation/LeetCodePlusNavigation.kt
This commit replaces the String-based navigation routes with Serializable objects for better type safety and clarity in the navigation graph.
nur-shuvo
approved these changes
May 13, 2025
|
@NiazSagor Thanks for the contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit refactors the navigation within the application to use Compose Navigation Safe Args. Key changes include:
LeetCodePlusNavGraphto use the new sealed class destinations and thetoRouteextension function for argument handling in the WebView screen.LeetCodePlusNavigationto accept and navigate using the sealed class objects.kotlinx.serialization.jsondependency and the corresponding Kotlin serialization plugin for handling navigation arguments.callerparameter from theWebViewScreencomposable.Android Doc: https://developer.android.com/guide/navigation/design/type-safety