Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] Forbidden final classes exclude #326

Merged
merged 5 commits into from
Dec 1, 2019
Merged

[Fix] Forbidden final classes exclude #326

merged 5 commits into from
Dec 1, 2019

Conversation

jochensengier
Copy link
Contributor

Q A
Bug fix? yes
New feature? no
Fixed tickets #325

Jibbarth
Jibbarth reviewed Nov 27, 2019
View reviewed changes
Copy link
Collaborator

@Jibbarth Jibbarth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great 👍 Are you able to add tests ? If you cannot, don't worry, I'll add them later 😉

@jochensengier
Copy link
Contributor Author

@Jibbarth Please keep in mind I don't have a lot of experience writing tests, but I gave it a try.
Could you triple check please?

Jibbarth
Jibbarth requested changes Nov 28, 2019
View reviewed changes
Copy link
Collaborator

@Jibbarth Jibbarth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding tests ! We're almost there 😉

src/Domain/Metrics/Architecture/Classes.php Outdated Show resolved Hide resolved
tests/Domain/Insights/ForbiddenFinalClassTest.php Show resolved Hide resolved
@jochensengier
Copy link
Contributor Author

Thanks for the suggestions, learned a lot!

@nunomaduro nunomaduro requested a review from Jibbarth November 29, 2019 08:38
Jibbarth
Jibbarth approved these changes Dec 1, 2019
View reviewed changes
Copy link
Collaborator

@Jibbarth Jibbarth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for this PR 😍

I added one more little commit to properly handle excluded files, that I noticed something don't work with the assert(1, $errors) in the tests you added

@Jibbarth Jibbarth merged commit e360528 into nunomaduro:master Dec 1, 2019
@Jibbarth Jibbarth added the bug Something isn't working label Dec 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jibbarth Jibbarth Jibbarth approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jochensengier @Jibbarth