Add checkstyle formatter

[bu4ak]

Q	A
Bug fix?	no
New feature?	yes

Added checkstyle formatter. It needs for ci.
This reporting format also supported by phpstan (larastan).

[olivernybroe]

Ah this is pretty cool, never heard of checkstyle before.
Nice contribution! ❤️

[nunomaduro]

I would remove this.

[nunomaduro]

@olivernybroe What do you think?

[nunomaduro]

@bu4ak I don't know this format, can you add documentation about it on the website?

[dmitryuk]

It's hard to find xml structure, but you can see phpstan's implementation
https://github.com/phpstan/phpstan/blob/395539e57f5b84356282257c7c950b6dbb7fbed2/src/Command/ErrorFormatter/CheckstyleErrorFormatter.php

It's schema
https://github.com/K-Phoen/PHP-CS-Fixer/blob/dd96fc45c0b44df9236f1dbdad9815a8865c2b72/doc/checkstyle.xsd

[olivernybroe]

@olivernybroe What do you think?

I think it looks good. I cannot verify if he implemented it correctly, but it looks pretty solid and I'll just trust him that he knows the standard.

It looks like this is something often used with Jenkins and is the format is originally from Java. I think it's a good addition and something that we could keep having support for.
The format looks pretty basic, and as long as we don't change our API for the Details object, there shouldn't be that much maintaining.

@bu4ak If you could fix the style tests that are failing and just add a few lines about it in the docs. Then I'll say it's ready to get merged. 😄

[dmitryuk]

If you could fix the style tests that are failing

@olivernybroe could you help to understand what is a problem?
I think the problem is that
‘24 Constructor of class
NunoMaduro\PhpInsights\Application\Console\Formatters\Checkstyle has an
unused parameter $input. ‘
But Json.php formatter doesn't use $input too and no any errors

phpinsights/src/Application/Console/Formatters/Json.php

Line 24 in 5d011f0

public function __construct(InputInterface $input, OutputInterface $output)

[dmitryuk]

Example checkstyle interface in teamcity (java code)

[olivernybroe]

@dmitryuk There are some errors.

One of them is you have an unused import of the Exception class.

To fix that one, do the same as we did for the json formatter, by adding a line in the phpstan file.

phpinsights/phpstan.neon.dist

Line 26 in 5d011f0

- '#NunoMaduro\\PhpInsights\\Application\\Console\\Formatters\\Json has an unused parameter \$input#'

You can test it locally by running composer test.

[dmitryuk]

@olivernybroe
@nunomaduro
All review issues are resolved.

[olivernybroe]

Looks good.
Thanks for the contribution! 👍

[dmitryuk]

Please release new version.