Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add package publish command for laravel users to the readme file #268

Merged
merged 1 commit into from
Sep 17, 2019

Conversation

paulayuk
Copy link
Contributor

@paulayuk paulayuk commented Sep 17, 2019

Q A
Bug fix? no
New feature? no
Fixed tickets none

This PR is meant to add a piece of small but useful information to the readme. For laravel users, you need to first publish the config file before using the package. If you don't, laravel will prompt you to by providing you with the php artisan vendor:publish command that will display all the current packages on your app as a list for you to select from. I believe this should immediately be pointed out in the readme so it becomes immediately obvious.

Copy link
Collaborator

@olivernybroe olivernybroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Yep it totally belongs here.

@nunomaduro nunomaduro merged commit 5d011f0 into nunomaduro:master Sep 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants