add braces in correct spots (#632)

nunomaduro · Mar 18, 2023 · 5bf3b17 · 5bf3b17
1 parent f5c7f6b
commit 5bf3b17
Show file tree

Hide file tree

Showing 5 changed files with 7 additions and 7 deletions.
diff --git a/src/Application/Console/Formatters/Console.php b/src/Application/Console/Formatters/Console.php
@@ -197,7 +197,7 @@ public function formatFix(InsightCollection $insightCollection, array $metrics):
                 if ($insight->getTotalFix() === 0) {
                     continue;
                 }
-                $fix = "<fg=green>• [$category] </><bold>{$insight->getTitle()}</bold>:";
+                $fix = "<fg=green>• [{$category}] </><bold>{$insight->getTitle()}</bold>:";
 
                 $details = $insight->getFixPerFile();
                 /** @var Details $detail */
@@ -380,7 +380,7 @@ private function issues(InsightCollection $insightCollection, array $metrics, st
 
                 $previousCategory = $category;
 
-                $issue = "\n<fg=red>•</> [$category] <bold>{$insight->getTitle()}</bold>";
+                $issue = "\n<fg=red>•</> [{$category}] <bold>{$insight->getTitle()}</bold>";
 
                 if (! $insight instanceof HasDetails && ! $this->style->getOutput()->isVerbose()) {
                     $this->style->writeln($issue);
@@ -419,7 +419,7 @@ private function issues(InsightCollection $insightCollection, array $metrics, st
                         $detailString .= ($detailString !== '' ? ': ' : '') . $this->parseDetailMessage($detail);
                     }
 
-                    $issue .= "\n  $detailString";
+                    $issue .= "\n  {$detailString}";
                 }
 
                 if (! $this->style->getOutput()->isVerbose() && $totalDetails > 3) {

diff --git a/src/Domain/Insights/CyclomaticComplexityIsHigh.php b/src/Domain/Insights/CyclomaticComplexityIsHigh.php
@@ -51,7 +51,7 @@ public function process(): void
 
         $this->details = array_map(static fn ($class, $complexity): Details => Details::make()
             ->setFile($class)
-            ->setMessage("$complexity cyclomatic complexity"), array_keys($classesComplexity), $classesComplexity);
+            ->setMessage("{$complexity} cyclomatic complexity"), array_keys($classesComplexity), $classesComplexity);
     }
 
     private function getMaxComplexity(): int

diff --git a/src/Domain/Insights/ForbiddenGlobals.php b/src/Domain/Insights/ForbiddenGlobals.php
@@ -36,7 +36,7 @@ public function getDetails(): array
             }
 
             $details[] = Details::make()->setFile($file)->setMessage(
-                "Usage of $global found; Usage of GLOBALS are discouraged consider not relying on global scope"
+                "Usage of {$global} found; Usage of GLOBALS are discouraged consider not relying on global scope"
             );
         }
 

diff --git a/src/Domain/Insights/ForbiddenSecurityIssues.php b/src/Domain/Insights/ForbiddenSecurityIssues.php
@@ -146,7 +146,7 @@ private function addIssuesDetails(string $packageName, string $version, array $i
                 continue;
             }
             self::$details[] = Details::make()->setMessage(
-                "$packageName@$version {$issue['title']} - {$issue['link']}"
+                "{$packageName}@{$version} {$issue['title']} - {$issue['link']}"
             );
         }
     }

diff --git a/src/Domain/Results.php b/src/Domain/Results.php
@@ -170,6 +170,6 @@ private function getInsightByCategory(string $insightClass, string $category): I
             }
         }
 
-        throw new InsightClassNotFound("$insightClass not found in $category");
+        throw new InsightClassNotFound("{$insightClass} not found in {$category}");
     }
 }
-Original file line number
+Diff line change
@@ Expand Up / @@ -36,7 +36,7 @@ public function getDetails(): array @@
                 }
                 $details[] = Details::make()->setFile($file)->setMessage(
-                    "Usage of $global found; Usage of GLOBALS are discouraged consider not relying on global scope"
+                    "Usage of {$global} found; Usage of GLOBALS are discouraged consider not relying on global scope"
                 );
             }
@@ Expand Down @@