Skip to content

Replace strictBooleans set with codingStyle set #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Replace strictBooleans set with codingStyle set #12

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
22b4787
add codingStyle set, remove strictBooleans set
thomasdail Oct 24, 2025
abf7e42
skip MakeInheritedMethodVisibilitySameAsParentRector rule
thomasdail Oct 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,17 +11,17 @@
"require": {
"php": "^8.4.0",
"inertiajs/inertia-laravel": "^2.0.10",
"laravel/fortify": "^1.31.1",
"laravel/framework": "^12.33",
"laravel/fortify": "^1.31.2",
"laravel/framework": "^12.35.1",
"laravel/tinker": "^2.10.1",
"laravel/wayfinder": "^0.1.12",
"nunomaduro/essentials": "^1.0.1"
},
"require-dev": {
"driftingly/rector-laravel": "^2.0.7",
"driftingly/rector-laravel": "^2.1.1",
"fakerphp/faker": "^1.24.1",
"larastan/larastan": "^3.7.2",
"laravel/boost": "^1.3.0",
"laravel/boost": "^1.5.0",
"laravel/pail": "^1.2.3",
"laravel/pint": "^1.25.1",
"mockery/mockery": "^1.6.12",
Expand All @@ -30,7 +30,7 @@
"pestphp/pest-plugin-browser": "^4.1.1",
"pestphp/pest-plugin-laravel": "^4.0.0",
"pestphp/pest-plugin-type-coverage": "^4.0.2",
"rector/rector": "^2.2.2",
"rector/rector": "^2.2.5",
"roave/security-advisories": "dev-latest"
},
"autoload": {
Expand Down
6 changes: 5 additions & 1 deletion rector.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@
declare(strict_types=1);

use Rector\Caching\ValueObject\Storage\FileCacheStorage;
use Rector\CodingStyle\Rector\ClassMethod\MakeInheritedMethodVisibilitySameAsParentRector;
use Rector\CodingStyle\Rector\Use_\SeparateMultiUseImportsRector;
use Rector\Config\RectorConfig;
use Rector\Php83\Rector\ClassMethod\AddOverrideAttributeToOverriddenMethodsRector;
use RectorLaravel\Set\LaravelSetList;
Expand Down Expand Up @@ -38,13 +40,15 @@
])
->withSkip([
AddOverrideAttributeToOverriddenMethodsRector::class,
SeparateMultiUseImportsRector::class,
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This rule seems annoying. I don't know what you think.

MakeInheritedMethodVisibilitySameAsParentRector::class,
])
->withPreparedSets(
deadCode: true,
codeQuality: true,
typeDeclarations: true,
privatization: true,
earlyReturn: true,
strictBooleans: true,
codingStyle: true,
)
->withPhpSets();
1 change: 1 addition & 0 deletions tests/Unit/Actions/CreateUserEmailResetNotificationTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@

// Send multiple reset requests to trigger throttling
$action->handle(['email' => $user->email]);

$status = $action->handle(['email' => $user->email]);

expect($status)->toBe(Password::RESET_THROTTLED);
Expand Down