Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support new error solutions package #308

Merged
merged 1 commit into from
Jul 16, 2024
Merged

Conversation

freekmurze
Copy link
Contributor

This PR adds support for the new error solutions package.

This solutions package is extracted out of the old Ignition error package so we can use it in both the new Flare client package and new package to display solutions on the default Laravel error page.

@mbardelmeijer
Copy link

We're seeing errors in our projects without this fix. Any change to get this merged & released?

i.e.

PHP Fatal error:  Uncaught TypeError: NunoMaduro\Collision\Adapters\Laravel\IgnitionSolutionsRepository::__construct(): Argument #1 ($solutionProviderRepository) must be of type Spatie\Ignition\Contracts\SolutionProviderRepository, Spatie\ErrorSolutions\SolutionProviderRepository given, called in /home/michel/code/enflow/clients/xxx/vendor/nunomaduro/collision/src/Adapters/Laravel/CollisionServiceProvider.php on line 49 and defined in /home/michel/code/enflow/clients/xxx/vendor/nunomaduro/collision/src/Adapters/Laravel/IgnitionSolutionsRepository.php:26

@nunomaduro nunomaduro merged commit 9b16be6 into nunomaduro:v8.x Jul 16, 2024
0 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants