Removed composer.lock #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
joaorobertopb
commented
Oct 12, 2017
joaorobertopb
commented
- Added composer.lock to .gitignore file
- Organizing .gitignore file
- Added composer.lock to .gitignore file - Organizing .gitignore file
nunomaduro
requested changes
Oct 12, 2017
| .twgit_features_subject | ||
|
|
||
| composer.lock |
There was a problem hiding this comment.
The composer.lock should always be committed.
There was a problem hiding this comment.
No, not for packages. When used in a package it only serves to speed up CI builds. The projects that require this package will ignore the lock file entirely. Only a top-level lock file is ever used by Composer. This also means that CI won't run against the latest dependencies as would happen when used in actual projects / applications.
There was a problem hiding this comment.
It is not common committed composer.lock in packages.
@thecrypticace great explanation!
There was a problem hiding this comment.
@joaorobertopb @thecrypticace You guys are both right. Thanks for the explanation!
Closed
|
Thanks for the contribution! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.