Skip to content

Conversation

@CharliePoole
Copy link
Member

Fixes #551

Everything is tested except for publishing source to myget. We can only see that work after merging.

Copy link
Member

@mikkelbu mikkelbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of comments/questions

Comment on lines -71 to -72
HasDirectory("NUnit.org/nunit-console/agents/net20").WithFiles("nunit-agent.exe", "nunit-agent.exe.config", "nunit-agent-x86.exe", "nunit-agent-x86.exe.config", "nunit.agent.addins"),
HasDirectory("NUnit.org/nunit-console/agents/net40").WithFiles("nunit-agent.exe", "nunit-agent.exe.config", "nunit-agent-x86.exe", "nunit-agent-x86.exe.config", "nunit.agent.addins"),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like these two have disappeared. Is that on purpose?

Copy link
Member

@rprouse rprouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me except for the two lines that @mikkelbu mentioned.

@CharliePoole
Copy link
Member Author

It has been a long time since I submitted this but IIRC those two lines failed. Some checks couldn't be done on the msi because I used an administrative install to do the checking. That expands the msi but doesn't put everything in its final location. Using a normal install might be possible if somebody wants to try it but it requires permissions the test runner doesn't normally have. I think I just decided to skip that particular check as an easy out.

@mikkelbu
Copy link
Member

mikkelbu commented Nov 4, 2021

It has been a long time since I submitted this but IIRC those two lines failed. Some checks couldn't be done on the msi because I used an administrative install to do the checking. That expands the msi but doesn't put everything in its final location. Using a normal install might be possible if somebody wants to try it but it requires permissions the test runner doesn't normally have. I think I just decided to skip that particular check as an easy out.

I can live with leaving these lines out. I'll merge it now and then we can always improve on this, if we feel for it later on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make engine easier to Debug

4 participants