-
Notifications
You must be signed in to change notification settings - Fork 162
Include pdbs with nuget and zip packges and publish source code #957
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
mikkelbu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of comments/questions
| HasDirectory("NUnit.org/nunit-console/agents/net20").WithFiles("nunit-agent.exe", "nunit-agent.exe.config", "nunit-agent-x86.exe", "nunit-agent-x86.exe.config", "nunit.agent.addins"), | ||
| HasDirectory("NUnit.org/nunit-console/agents/net40").WithFiles("nunit-agent.exe", "nunit-agent.exe.config", "nunit-agent-x86.exe", "nunit-agent-x86.exe.config", "nunit.agent.addins"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like these two have disappeared. Is that on purpose?
rprouse
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me except for the two lines that @mikkelbu mentioned.
|
It has been a long time since I submitted this but IIRC those two lines failed. Some checks couldn't be done on the msi because I used an administrative install to do the checking. That expands the msi but doesn't put everything in its final location. Using a normal install might be possible if somebody wants to try it but it requires permissions the test runner doesn't normally have. I think I just decided to skip that particular check as an easy out. |
I can live with leaving these lines out. I'll merge it now and then we can always improve on this, if we feel for it later on. |
Fixes #551
Everything is tested except for publishing source to myget. We can only see that work after merging.