Eliminate double-loading of assemblies #1806
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CharliePoole
force-pushed
the
adapter-1389
branch
from
4eaa045 to
aa0fd11
Compare
manfred-brands
approved these changes
Dec 25, 2025
| Assemblies = new ExpectedAssemblyResult[] { new ExpectedAssemblyResult("AppContextTest.dll", "netcore-8.0") } | ||
| } | ||
| }); | ||
| //StandardAndZipLists.Add(new PackageTest(1, "AppContextBaseDirectory_NET80") |
Member
There was a problem hiding this comment.
Can the commented out code be deleted
| StringComparer.OrdinalIgnoreCase.Equals(Path.GetFullPath(a.Location), full)); | ||
| } | ||
|
|
||
| public static Assembly FindLoadedAssemblyByName(AssemblyName assemblyName) |
Member
Author
|
@manfred-brands Thanks for the review. I ended up re-creating this PR under another name and merging that instead. Removed the commented out stuff but kept an unused method because I want to experiment with it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1807