v4: Remove deprecated --params option

[ChrisMaddock]

[GitClickOk]

@ChrisMaddock, I see here since the 3.10 version the --params option is deprecated in favor of --testparam option. Please, update the docs then, there is no reference to --testparam option, and nothing about syntax too. The deprecation note will be nice too.

PS: (If the docs are open source, and if you want I can try contribute and update myself)

[ChrisMaddock]

Hi @GitClickOk - a contribution to the docs would be really appreciated! Just click the "Improve this Doc" link in the top right of the page, which will take you to the relevant GitHub repo. 🙂 Let us know if you have any problems.

[GitClickOk]

@ChrisMaddock FYI I have created a PR for suggested change in the docs. I saw the markdown was broken in --param option and I have fixed too: nunit/docs#555

I hope is everything ok, this is the first time I create a PR in GitHub, I work only with BitBucket :)

[ChrisMaddock]

That looks great - thanks @GitClickOk! Appreciate the help! 😄

[CharliePoole]

@jnm2 @mikkelbu @rprouse

Since we are breaking things for 4.0 anyway, my inclination is to use the syntax and implementation of --testParams but go back the original naming of --params. What do you think?

[jnm2]

I'm fine with it.

[rprouse]

I'm good with it too. Are we planning on using a different executable name for 4?

[CharliePoole]

I never thought about it but obviously nunit3-console isn't good any more! I'll make an issue.