[poincare] Add parenthesis at serialization with LogicalOperator

numworks · Apr 17, 2024 · 4072bfd · 4072bfd
1 parent edd5ea8
commit 4072bfd
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 1 deletion.
diff --git a/poincare/src/division.cpp b/poincare/src/division.cpp
@@ -52,7 +52,8 @@ bool DivisionNode::childNeedsSystemParenthesesAtSerialization(
   return static_cast<const ExpressionNode *>(child)->isOfType(
       {Type::Subtraction, Type::Opposite, Type::Multiplication, Type::Division,
        Type::Addition, Type::PercentSimple, Type::PercentAddition,
-       Type::MixedFraction, Type::Comparison});
+       Type::MixedFraction, Type::Comparison, Type::LogicalOperatorNot,
+       Type::BinaryLogicalOperator});
 }
 
 size_t DivisionNode::serialize(char *buffer, size_t bufferSize,

diff --git a/poincare/test/expression_serialization.cpp b/poincare/test/expression_serialization.cpp
@@ -1,3 +1,4 @@
+#include <poincare/absolute_value.h>
 #include <poincare/addition.h>
 #include <poincare/based_integer.h>
 #include <poincare/comparison.h>
@@ -11,6 +12,7 @@
 #include <poincare/infinity.h>
 #include <poincare/logical_operator.h>
 #include <poincare/opposite.h>
+#include <poincare/parenthesis.h>
 #include <poincare/percent.h>
 #include <poincare/power.h>
 #include <poincare/rational.h>
@@ -314,6 +316,17 @@ QUIZ_CASE(poincare_serialization_power) {
                      BinaryLogicalOperator::Builder(
                          BasedInteger::Builder(3), BasedInteger::Builder(4),
                          BinaryLogicalOperatorNode::OperatorType::Or))));
+  assert_expression_serializes_and_parses_to_itself(
+      AbsoluteValue::Builder(PercentAddition::Builder(
+          BasedInteger::Builder(0),
+          Division::Builder(
+              BasedInteger::Builder(0),
+              BinaryLogicalOperator::Builder(
+                  Symbol::Builder("r", 1),
+                  Multiplication::Builder(
+                      Symbol::Builder("o", 1), Symbol::Builder("m0", 2),
+                      Parenthesis::Builder(BasedInteger::Builder(0))),
+                  BinaryLogicalOperatorNode::OperatorType::And)))));
 }
 
 QUIZ_CASE(poincare_serialization_derivative) {