Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add golines formatter #319

Merged
merged 4 commits into from
Mar 18, 2025
Merged

feat: add golines formatter #319

merged 4 commits into from
Mar 18, 2025

Conversation

gabyx
Copy link
Contributor

@gabyx gabyx commented Mar 4, 2025

  • Add the golines formatter.
  • Only use it with --no-reformat-tags due to bugs (destructive operation).

@zimbatm
Copy link
Member

zimbatm commented Mar 5, 2025

looks good but needs the example from ./examples.sh as well

@gabyx
Copy link
Contributor Author

gabyx commented Mar 7, 2025

oh shit forgot, will add it.

@zimbatm
Copy link
Member

zimbatm commented Mar 10, 2025

and the README formatting :)

@gabyx
Copy link
Contributor Author

gabyx commented Mar 10, 2025

ah I should read the contr. guidlines better. sorry check tomorrow.

@gabyx
Copy link
Contributor Author

gabyx commented Mar 11, 2025

@zimbatm : Added hint to the contrib section and fixes the README.

@zimbatm zimbatm merged commit 7620ff4 into numtide:main Mar 18, 2025
3 checks passed
@zimbatm
Copy link
Member

zimbatm commented Mar 18, 2025

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants