dos2unix: explicitly set mainProgram to dos2unix
#295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebaszv
force-pushed
the
dosunix_set-mainProgram
branch
3 times, most recently
from
d942725 to
110ae33
Compare
sebaszv
changed the title
mainProgram to dos2unix
The package `dos2unix` doesn't have `meta.mainProgram` defined since it includes several binaries. At present `lib.getExe` was inferring that we wanted the path to `dos2unix`. Here we now specify that we want `dos2unix`, avoiding what is specified in the evaluation warning: > *evaluation warning:* `getExe`: Package "dos2unix-7.5.2" does not have > the `meta.mainProgram` attribute. We'll assume that the main program > has the same name for now, but this behavior is deprecated, because > it leads to surprising errors when the assumption does not hold. If > the package has a main program, please set `meta.mainProgram` in its > definition to make this warning go away. Otherwise, if the package > does not have a main program, or if you don't control its definition, > use `getExe'` to specify the name to the program, such as > `lib.getExe' foo "bar"`. I also added myself to the maintainers list.
sebaszv
force-pushed
the
dosunix_set-mainProgram
branch
from
110ae33 to
2027acc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The package
dos2unixdoesn't havemeta.mainProgramdefined since it includes several binaries.
At present
lib.getExewas inferring that we wanted thepath to
dos2unix.Here we now specify that we want
dos2unix, avoidingwhat is specified in the evaluation warning: