Fixes #293
Merged
Fixes #293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roberth
commented
Jan 3, 2025
| inherit mkFormatterModule; | ||
| }; | ||
|
|
||
| /** |
There was a problem hiding this comment.
I've take the liberty to use the new, standard doc comment syntax, and the documentation conventions Nixpkgs uses.
roberth
commented
Jan 3, 2025
programs/genemichaels.nix
Outdated
Comment on lines
29
to
33
|
|
||
| showOptionParent = opt: n: | ||
| assert opt._type == "option"; | ||
| lib.showOption (lib.take (lib.length opt.loc - 1) opt.loc); |
There was a problem hiding this comment.
This makes `default.nix` the "thin waist" entrypoint of the project, making `flake-module.nix` a mere "helper" that uses a function from `default.nix`. The new `submoduleWith` includes `mkFormatterModule` which was accidentally forgotten in an earlier commit.
Also fixes an evaluation error
|
Just as I was wondering how to interpret your comment about submoduleWith correctly, there's already a PR - Thank you! EDIT: tested the wrong commit, this one works fine :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
submoduleWithfunction to lib, to make the alternate entrypoint contract visible (it's different wrtpkgsand return value - see doc)