Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update nixpkgs input #289

Merged
merged 2 commits into from
Jan 2, 2025

Conversation

djacu
Copy link
Contributor

@djacu djacu commented Dec 31, 2024

Brings in genemichaels 0.5.13 (latest).

Brings in genemichaels 0.5.13 (latest).
@djacu
Copy link
Contributor Author

djacu commented Dec 31, 2024

Brings in an update for #277

@zimbatm
Copy link
Member

zimbatm commented Jan 1, 2025

thanks. it looks like formatjson5 and elm-format are having some issues.

@djacu
Copy link
Contributor Author

djacu commented Jan 2, 2025

Yeah they are both failing upstream.

https://hydra.nixos.org/build/282571175
https://hydra.nixos.org/build/282877962

I think formatjson5 has started failing because of the new changes to missing_docs in Rust 1.83.
https://releases.rs/docs/1.83.0/
Since the repository has not had any commits in ~1 year, I think it's best to patch it.

Not sure why elm-format has started failing. The hydra logs return a 404 and it only appears to be affecting Darwin. I don't have a capable machine handy so it'll be hard for me to debug. :/

@djacu
Copy link
Contributor Author

djacu commented Jan 2, 2025

I've got a PR in to fix formatjson5
NixOS/nixpkgs#370124

Looks like someone else has noticed that elm-format is broken as well.
NixOS/nixpkgs#370084

@zimbatm
Copy link
Member

zimbatm commented Jan 2, 2025

Let's add elm-format to the

# Add formatters that don't work fully here.
broken-formatters =
[
# See https://github.com/numtide/treefmt-nix/pull/201
"swift-format"
]
# Broken on macOS
++ (lib.optionals pkgs.stdenv.isDarwin [
"fantomas"
"gdformat"
"muon"
]);
list until it gets fixed.
At some point I need to find a better way to handle arch-specific broken formatters.

@zimbatm zimbatm force-pushed the djacu/update-nixpkgs-flake-input branch from b88ac17 to 6e43007 Compare January 2, 2025 14:16
@zimbatm zimbatm enabled auto-merge (squash) January 2, 2025 14:17
@zimbatm zimbatm merged commit 246639a into numtide:main Jan 2, 2025
3 checks passed
@djacu djacu deleted the djacu/update-nixpkgs-flake-input branch January 2, 2025 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants